Issue 27033009: Making all base class DOM types throw as well (to prevent a default constructor for DOM types that …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27033009: Making all base class DOM types throw as well (to prevent a default constructor for DOM types that … (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable). BUG=https://code.google.com/p/dart/issues/detail?id=11620 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28615

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+926 lines, -17 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	145 chunks	+291 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	150 chunks	+302 lines, -7 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	6 chunks	+14 lines, -2 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	6 chunks	+14 lines, -2 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	37 chunks	+74 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	37 chunks	+74 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	29 chunks	+58 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	29 chunks	+58 lines, -0 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	6 chunks	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	6 chunks	+12 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Emily Fortuna

I'm a bit suspicious. This feels too easy. But all the html tests passed..!

7 years, 2 months ago (2013-10-14 21:52:30 UTC) #1

Emily Fortuna

7 years, 2 months ago (2013-10-14 21:59:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28615 (presubmit successful).