Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: sdk/lib/web_audio/dartium/web_audio_dartium.dart

Issue 27033009: Making all base class DOM types throw as well (to prevent a default constructor for DOM types that … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_audio/dart2js/web_audio_dart2js.dart ('k') | sdk/lib/web_gl/dart2js/web_gl_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/web_audio/dartium/web_audio_dartium.dart
diff --git a/sdk/lib/web_audio/dartium/web_audio_dartium.dart b/sdk/lib/web_audio/dartium/web_audio_dartium.dart
index b6c10038cfdcf31aa569e49e2243e35fac240dff..5568efafff7a574056c4a9a1274e0252c10c1c44 100644
--- a/sdk/lib/web_audio/dartium/web_audio_dartium.dart
+++ b/sdk/lib/web_audio/dartium/web_audio_dartium.dart
@@ -89,6 +89,8 @@ class AnalyserNode extends AudioNode {
// https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
@Experimental()
class AudioBuffer extends NativeFieldWrapperClass1 {
+ // To suppress missing implicit constructor warnings.
+ factory AudioBuffer._() { throw new UnsupportedError("Not supported"); }
@DomName('AudioBuffer.duration')
@DocsEditable()
@@ -509,6 +511,8 @@ class AudioDestinationNode extends AudioNode {
// https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioListener-section
@Experimental()
class AudioListener extends NativeFieldWrapperClass1 {
+ // To suppress missing implicit constructor warnings.
+ factory AudioListener._() { throw new UnsupportedError("Not supported"); }
@DomName('AudioListener.dopplerFactor')
@DocsEditable()
@@ -639,6 +643,8 @@ class AudioNode extends EventTarget {
// https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioParam
@Experimental()
class AudioParam extends NativeFieldWrapperClass1 {
+ // To suppress missing implicit constructor warnings.
+ factory AudioParam._() { throw new UnsupportedError("Not supported"); }
@DomName('AudioParam.defaultValue')
@DocsEditable()
@@ -1315,6 +1321,8 @@ class PannerNode extends AudioNode {
@DomName('PeriodicWave')
@Experimental() // untriaged
class PeriodicWave extends NativeFieldWrapperClass1 {
+ // To suppress missing implicit constructor warnings.
+ factory PeriodicWave._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
« no previous file with comments | « sdk/lib/web_audio/dart2js/web_audio_dart2js.dart ('k') | sdk/lib/web_gl/dart2js/web_gl_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698