tools/dom/scripts/htmldartgenerator.py - Issue 27033009: Making all base class DOM types throw as well (to prevent a default constructor for DOM types that …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 27033009: Making all base class DOM types throw as well (to prevent a default constructor for DOM types that … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index c53d51a95d8a3987987b2bb4a35955e4b2c20978..43114ee828a23bed333279e69428731438a63e0f 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -598,8 +598,7 @@ class HtmlDartGenerator(object):

if not self._members_emitter:

return

- if (base_class != self.RootClassName() and

- self._interface.id not in custom_html_constructors):

+ if self._interface.id not in custom_html_constructors:

self._members_emitter.Emit(

' // To suppress missing implicit constructor warnings.\n'

' factory $CLASSNAME._() { '

« no previous file with comments | « sdk/lib/web_sql/dartium/web_sql_dartium.dart ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »