Issue 13918. final fields induce setters that are illegal to call

Issue 13918. final fields induce setters that are illegal to call
https://code.google.com/p/dart/issues/detail?id=13918

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=28415

[Brian Wilkerson, 2013-10-09 19:57:48]

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
(right):

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:763:
{
nit: please remove the unnecessary block

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
(right):

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java:1741:
assertErrors(source,
StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
Sorry, but I'm not understanding why there is a warning here. What is the
abstract member we're warning about?

[scheglov, 2013-10-09 20:04:00]

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
(right):

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:763:
{
On 2013/10/09 19:57:48, Brian Wilkerson wrote:
> nit: please remove the unnecessary block

Done.

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
(right):

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java:1741:
assertErrors(source,
StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
On 2013/10/09 19:57:48, Brian Wilkerson wrote:
> Sorry, but I'm not understanding why there is a warning here. What is the
> abstract member we're warning about?

The most recent spec:
------------
A final or constant variable declaration of the form final T v;, final T v = e;
or the form  
const T v = e;  always induces an implicit  setter function with signature 

void set v=(T x)

whose execution causes a runtime exception. It is a static warning to invoke
such a setter.
------------

Here A.x declares both getter and setter.
Invocation of this setter is a warning.
But it still exists.
So, when we implement A, we need to implement it too.

Confusing? Agree.

[Brian Wilkerson, 2013-10-09 20:20:53]

LGTM

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
(right):

https://codereview.chromium.org/26746002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java:1741:
assertErrors(source,
StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
> So, when we implement A, we need to implement it too.

Ah! I missed the 'implements' (I think I read 'extends'). Now it makes sense.

[scheglov, 2013-10-09 20:30:52]

Committed patchset #1 manually as r28415 (presubmit successful).