editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java - Issue 26746002: Issue 13918. final fields induce setters that are illegal to call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

Issue 26746002: Issue 13918. final fields induce setters that are illegal to call (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/PropertyAccessorElement.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyAccessorElementImpl.java » ('j') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

index bef3128649b3c5392e3bb026282c7a6c9ee7f360..1e337b461ecdf786f849fe59a491ba245ce9316d 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

@@ -760,7 +760,7 @@ public class ElementBuilder extends RecursiveASTVisitor<Void> {

currentHolder.addAccessor(getter);

variable.setGetter(getter);

- if (!isFinal) {

+ {

Brian Wilkerson 2013/10/09 19:57:48 nit: please remove the unnecessary block

scheglov 2013/10/09 20:04:00 Done.

PropertyAccessorElementImpl setter = new PropertyAccessorElementImpl(variable);

setter.setSetter(true);

setter.setStatic(variable.isStatic());