Issue 13918. final fields induce setters that are illegal to call

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
@@ skipping 742 matching lines @@
             Keyword.STATIC));
       }
 
       PropertyAccessorElementImpl getter = new PropertyAccessorElementImpl(variable);
       getter.setGetter(true);
       getter.setStatic(variable.isStatic());
 
       currentHolder.addAccessor(getter);
       variable.setGetter(getter);
 
-      if (!isFinal) {
+      {

[Brian Wilkerson, 2013/10/09 19:57:48]

nit: please remove the unnecessary block

[scheglov, 2013/10/09 20:04:00]

Done.

         PropertyAccessorElementImpl setter = new PropertyAccessorElementImpl(variable);
         setter.setSetter(true);
         setter.setStatic(variable.isStatic());
         ParameterElementImpl parameter = new ParameterElementImpl(
             "_" + variable.getName(),
             variable.getNameOffset());
         parameter.setSynthetic(true);
         parameter.setParameterKind(ParameterKind.REQUIRED);
         setter.setParameters(new ParameterElement[] {parameter});
 
@@ skipping 112 matching lines @@
       ElementHolder previousHolder = currentHolder;
       currentHolder = holder;
       try {
         node.visitChildren(this);
       } finally {
         currentHolder = previousHolder;
       }
     }
   }
 }