Issue 264903005: [dart:html] rename custom elements callbacks to match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264903005: [dart:html] rename custom elements callbacks to match spec (Closed)

Created:
6 years, 7 months ago by Jennifer Messerly

Modified:
6 years, 7 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

[dart:html] rename custom elements callbacks to match spec Dartium side is forthcoming. Tests still using attached/detached until we have it in Dartium. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=35673

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -15 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+31 lines, -7 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+25 lines, -1 line	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+25 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jennifer Messerly

@Pete, does this seem a reasonable way to proceed with the rename? Land dart2js side, ...

6 years, 7 months ago (2014-05-01 23:58:47 UTC) #1

Jennifer Messerly

6 years, 7 months ago (2014-05-02 00:22:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35673 (presubmit successful).