Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 264903005: [dart:html] rename custom elements callbacks to match spec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/src/dart2js_CustomElementSupport.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 69b600bf94e614e6eafb2088f784bd1a839544cc..360e16f0db6738fdc066148045abbdcde7ba4704 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -9869,15 +9869,39 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
/**
* Called by the DOM when this element has been inserted into the live
* document.
+ *
+ * More information can be found in the
+ * [Custom Elements](http://w3c.github.io/webcomponents/spec/custom/#dfn-attached-callback)
+ * draft specification.
*/
@Experimental()
- void enteredView() {}
+ void attached() {
+ // For the deprecation period, call the old callback.
+ enteredView();
+ }
/**
* Called by the DOM when this element has been removed from the live
* document.
+ *
+ * More information can be found in the
+ * [Custom Elements](http://w3c.github.io/webcomponents/spec/custom/#dfn-detached-callback)
+ * draft specification.
*/
@Experimental()
+ void detached() {
+ // For the deprecation period, call the old callback.
+ leftView();
+ }
+
+ /** *Deprecated*: override [attached] instead. */
+ @Experimental()
+ @deprecated
+ void enteredView() {}
+
+ /** *Deprecated*: override [detached] instead. */
+ @Experimental()
+ @deprecated
void leftView() {}
/**
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/src/dart2js_CustomElementSupport.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698