Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 264903005: [dart:html] rename custom elements callbacks to match spec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/src/dart2js_CustomElementSupport.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 4155c8d849190d06c1c52fb44702c23a3dc84612..0005e02ffab1912d6a13580f7b92300de8601ad8 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -738,15 +738,39 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
/**
* Called by the DOM when this element has been inserted into the live
* document.
+ *
+ * More information can be found in the
+ * [Custom Elements](http://w3c.github.io/webcomponents/spec/custom/#dfn-attached-callback)
+ * draft specification.
*/
@Experimental()
- void enteredView() {}
+ void attached() {
+ // For the deprecation period, call the old callback.
+ enteredView();
+ }
/**
* Called by the DOM when this element has been removed from the live
* document.
+ *
+ * More information can be found in the
+ * [Custom Elements](http://w3c.github.io/webcomponents/spec/custom/#dfn-detached-callback)
+ * draft specification.
*/
@Experimental()
+ void detached() {
+ // For the deprecation period, call the old callback.
+ leftView();
+ }
+
+ /** *Deprecated*: override [attached] instead. */
+ @Experimental()
+ @deprecated
+ void enteredView() {}
+
+ /** *Deprecated*: override [detached] instead. */
+ @Experimental()
+ @deprecated
void leftView() {}
/**
« no previous file with comments | « tools/dom/src/dart2js_CustomElementSupport.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698