Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 264753002: Adds Simulator Longjmp and enables many tests for arm64. (Closed)

Created:
6 years, 7 months ago by zra
Modified:
6 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds Simulator Longjmp and enables many tests for arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -112 lines) Patch
M runtime/vm/benchmark_test.cc View 6 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/code_descriptors_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/dart_entry_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/exceptions_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/heap_test.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +77 lines, -6 lines 0 comments Download
M runtime/vm/isolate_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/json_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_id_ring_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 8 chunks +3 lines, -17 lines 0 comments Download
M runtime/vm/resolver_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/service_test.cc View 5 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/stack_frame_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 7 months ago (2014-04-30 22:47:07 UTC) #1
regis
LGTM
6 years, 7 months ago (2014-04-30 22:54:25 UTC) #2
zra
6 years, 7 months ago (2014-04-30 23:07:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698