Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5317)

Unified Diff: runtime/vm/object_test.cc

Issue 264753002: Adds Simulator Longjmp and enables many tests for arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_id_ring_test.cc ('k') | runtime/vm/resolver_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 35591)
+++ runtime/vm/object_test.cc (working copy)
@@ -2992,9 +2992,6 @@
}
-// TODO(zra): Enable test when arm64 is ready.
-#if !defined(TARGET_ARCH_ARM64)
-
TEST_CASE(StackTraceFormat) {
const char* kScriptChars =
"void baz() {\n"
@@ -3054,7 +3051,6 @@
"#9 main (dart:test-lib:37:24)");
}
-#endif // !defined(TARGET_ARCH_ARM64)
TEST_CASE(WeakProperty_PreserveCrossGen) {
Isolate* isolate = Isolate::Current();
@@ -3463,9 +3459,6 @@
}
-// TODO(zra): Enable test when arm64 is ready.
-#if !defined(TARGET_ARCH_ARM64)
-
static RawFunction* GetFunction(const Class& cls, const char* name) {
const Function& result = Function::Handle(cls.LookupDynamicFunction(
String::Handle(String::New(name))));
@@ -3605,9 +3598,7 @@
EXPECT_EQ(func_x.raw(), func_x_from_index.raw());
}
-#endif // !defined(TARGET_ARCH_ARM64)
-
TEST_CASE(FindClosureIndex) {
// Allocate the class first.
const String& class_name = String::Handle(Symbols::New("MyClass"));
@@ -3687,9 +3678,6 @@
}
-// TODO(zra): Enable test when arm64 is ready.
-#if !defined(TARGET_ARCH_ARM64)
-
static void PrintMetadata(const char* name, const Object& data) {
if (data.IsError()) {
OS::Print("Error in metadata evaluation for %s: '%s'\n",
@@ -3857,6 +3845,9 @@
}
+// TODO(zra): Enable test when arm64 is ready.
+#if !defined(TARGET_ARCH_ARM64)
+
TEST_CASE(FunctionWithBreakpointNotInlined) {
const char* kScriptChars =
"class A {\n"
@@ -3929,9 +3920,6 @@
}
-// TODO(zra): Enable test when arm64 is ready.
-#if !defined(TARGET_ARCH_ARM64)
-
TEST_CASE(ToUserCString) {
const char* kScriptChars =
"var simple = 'simple';\n"
@@ -4027,6 +4015,4 @@
heap->IterateObjects(&verifier);
}
-#endif // !defined(TARGET_ARCH_ARM64)
-
} // namespace dart
« no previous file with comments | « runtime/vm/object_id_ring_test.cc ('k') | runtime/vm/resolver_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698