Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: runtime/vm/service_test.cc

Issue 264753002: Adds Simulator Longjmp and enables many tests for arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/resolver_test.cc ('k') | runtime/vm/simulator_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
===================================================================
--- runtime/vm/service_test.cc (revision 35591)
+++ runtime/vm/service_test.cc (working copy)
@@ -2,9 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// TODO(zra): Remove when tests are ready to enable.
#include "platform/globals.h"
-#if !defined(TARGET_ARCH_ARM64)
#include "include/dart_debugger_api.h"
#include "vm/dart_api_impl.h"
@@ -1038,6 +1036,9 @@
}
+// TODO(zra): Remove when tests are ready to enable.
+#if !defined(TARGET_ARCH_ARM64)
+
TEST_CASE(Service_Coverage) {
const char* kScript =
"var port;\n" // Set to our mock port by C++.
@@ -1076,7 +1077,9 @@
"[5,1,6,1]}", handler.msg());
}
+#endif
+
TEST_CASE(Service_AllocationProfile) {
const char* kScript =
"var port;\n" // Set to our mock port by C++.
@@ -1321,6 +1324,10 @@
EXPECT_STREQ("beta", handler.msg());
}
+
+// TODO(zra): Remove when tests are ready to enable.
+#if !defined(TARGET_ARCH_ARM64)
+
TEST_CASE(Service_Profile) {
const char* kScript =
"var port;\n" // Set to our mock port by C++.
@@ -1367,6 +1374,6 @@
EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg());
}
+#endif // !defined(TARGET_ARCH_ARM64)
+
} // namespace dart
-
-#endif // !defined(TARGET_ARCH_ARM64)
« no previous file with comments | « runtime/vm/resolver_test.cc ('k') | runtime/vm/simulator_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698