Cleanups: int -> intptr_t for "array" lengths, memory sizes.

Cleanups: int -> intptr_t for "array" lengths, memory sizes.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28324

[srdjan, 2013-10-07 17:28:50]

First part of int -> intptr_t cleanups

[siva, 2013-10-07 19:40:29]

lgtm

https://codereview.chromium.org/26294002/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/ast.cc#newcode89
runtime/vm/ast.cc:89: OS::SNPrint(name, sizeof(name), ":lt%" Pd "_%"Pd"",
The Clang compiler will complain for this, need to add spaces.

"_%" Pd "",

https://codereview.chromium.org/26294002/diff/1/runtime/vm/bigint_operations.h
File runtime/vm/bigint_operations.h (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/bigint_operations....
runtime/vm/bigint_operations.h:151: static intptr_t CountBits(Chunk digit);
I am wondering if this needs to be int32_t (do we expect bit count to be larger
than a 32 bit value?).

https://codereview.chromium.org/26294002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:868: OS::PrintErr("InlineCacheMissHandler %"Pd"
call at %#" Px "' "
Ditto comment about using spaces.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner.cc
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:796: TRACE_INLINING(OS::Print("  Static Calls
(%"Pd")\n", call_info.length()));
Ditto.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:835: TRACE_INLINING(OS::Print("  Closure Calls
(%"Pd")\n", calls.length()));
Ditto.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:872: TRACE_INLINING(OS::Print("  Polymorphic
Instance Calls (%"Pd")\n",
Ditto.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/scanner_test.cc
File runtime/vm/scanner_test.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/scanner_test.cc#ne...
runtime/vm/scanner_test.cc:91: OS::PrintErr("Expected %d tokens but got only
%"Pd".\n",
Ditto.

[srdjan, 2013-10-07 20:02:59]

https://codereview.chromium.org/26294002/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/ast.cc#newcode89
runtime/vm/ast.cc:89: OS::SNPrint(name, sizeof(name), ":lt%" Pd "_%"Pd"",
On 2013/10/07 19:40:30, siva wrote:
> The Clang compiler will complain for this, need to add spaces.
> 
> "_%" Pd "",

Done.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/bigint_operations.h
File runtime/vm/bigint_operations.h (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/bigint_operations....
runtime/vm/bigint_operations.h:151: static intptr_t CountBits(Chunk digit);
On 2013/10/07 19:40:30, siva wrote:
> I am wondering if this needs to be int32_t (do we expect bit count to be
larger
> than a 32 bit value?).

Offline: leave it at intptr_t

https://codereview.chromium.org/26294002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:868: OS::PrintErr("InlineCacheMissHandler %"Pd"
call at %#" Px "' "
On 2013/10/07 19:40:30, siva wrote:
> Ditto comment about using spaces.

Done.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner.cc
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:796: TRACE_INLINING(OS::Print("  Static Calls
(%"Pd")\n", call_info.length()));
On 2013/10/07 19:40:30, siva wrote:
> Ditto.

Done.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:835: TRACE_INLINING(OS::Print("  Closure Calls
(%"Pd")\n", calls.length()));
On 2013/10/07 19:40:30, siva wrote:
> Ditto.

Done.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:872: TRACE_INLINING(OS::Print("  Polymorphic
Instance Calls (%"Pd")\n",
On 2013/10/07 19:40:30, siva wrote:
> Ditto.

Done.

https://codereview.chromium.org/26294002/diff/1/runtime/vm/scanner_test.cc
File runtime/vm/scanner_test.cc (right):

https://codereview.chromium.org/26294002/diff/1/runtime/vm/scanner_test.cc#ne...
runtime/vm/scanner_test.cc:91: OS::PrintErr("Expected %d tokens but got only
%"Pd".\n",
On 2013/10/07 19:40:30, siva wrote:
> Ditto.

Done.

[srdjan, 2013-10-07 20:19:53]

Committed patchset #2 manually as r28324.