dart2js: The name of a library without a library declaration is the empty string.

dart2js: The name of a library without a library declaration is the empty string.

BUG=http://dartbug.com/10580
R=gbracha@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29263

[gbracha, 2013-10-08 00:20:08]

Test lgtm

[ahe, 2013-10-10 11:47:53]

I'm concerned about the qualified name of an element in an unnamed library
starting with a period.

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (left):

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:697: String
getLibraryOrScriptName();
I think we need to keep this method for some situations.

Originally, it was added for dartdoc, and I'm not sure we can remove it yet.
Johnni: what do you think?

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:902: return
libraryTag.name.toString();
Perhaps we need to cache this value.

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:924: return
getLibraryName().compareTo(other.getLibraryName());
All the above should probably continue to use getLibraryOrScriptName.

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:586: name =
library.getLibraryName();
This change doesn't seem correct, as this method might now return an empty
string.

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:844:
library.getLibraryName().hashCode % userGlobalObjects.length];
I think we need to keep getLibraryOrScriptName. Otherwise, all unnamed libraries
hash to the same value.

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (left):

https://codereview.chromium.org/26291005/diff/12001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:1811: if (ownerName == '') return
simpleName;
This change does not make sense to me.

https://codereview.chromium.org/26291005/diff/12001/tests/lib/mirrors/unnamed...
File tests/lib/mirrors/unnamed_library_test.dart (right):

https://codereview.chromium.org/26291005/diff/12001/tests/lib/mirrors/unnamed...
tests/lib/mirrors/unnamed_library_test.dart:18: Expect.equals('.Class',
MirrorSystem.getName(cm.qualifiedName));
This doesn't make sense to me.

[rmacnak, 2013-10-22 20:34:15]

Backed out of refactoring the other users of getLibraryOrScriptName().

I still think the qualified name of a declaration in an unnamed library begins
with a period. In a REPL I imagine one would use the simple name anyway. Note
that our stack traces already do not use fully qualified names.

[Johnni Winther, 2013-10-25 06:11:33]

lgtm

[rmacnak, 2013-10-25 17:16:18]

Committed patchset #3 manually as r29263 (presubmit successful).