dart2js: The name of a library without a library declaration is the empty string.

sdk/lib/_internal/compiler/implementation/elements/modelx.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements.modelx;
 
 import 'dart:collection' show LinkedHashMap;
 
 import 'elements.dart';
 import '../../compiler.dart' as api;
@@ skipping 876 matching lines @@
     return localScope.values.where((Element element) {
       // At this point [localScope] only contains members so we don't need
       // to check for foreign or prefix elements.
       return !element.name.isPrivate();
     });
   }
 
   bool hasLibraryName() => libraryTag != null;
 
   /**
-   * Returns the library name (as defined by the library tag) or for script
-   * (which have no library tag) the script file name. The latter case is used
-   * to private 'library name' for scripts to use for instance in dartdoc.
+   * Returns the library name, which is either the name given in the library tag
+   * or the empty string if there is no library tag.
    */
-  String getLibraryOrScriptName() {
-    if (libraryTag != null) {
-      return libraryTag.name.toString();
-    } else {
-      // Use the file name as script name.
-      String path = canonicalUri.path;
-      return path.substring(path.lastIndexOf('/') + 1);
-    }
+  String getLibraryName() {
+    if (libraryTag == null) return '';
+    return libraryTag.name.toString();

[ahe, 2013/10/10 11:47:53]

Perhaps we need to cache this value.

   }
 
   Scope buildScope() => new LibraryScope(this);
 
   bool get isPlatformLibrary => canonicalUri.scheme == "dart";
 
   bool get isInternalLibrary =>
       isPlatformLibrary && canonicalUri.path.startsWith('_');
 
   String toString() {
     if (origin != null) {
-      return 'patch library(${getLibraryOrScriptName()})';
+      return 'patch library(${getLibraryName()})';
     } else if (patch != null) {
-      return 'origin library(${getLibraryOrScriptName()})';
+      return 'origin library(${getLibraryName()})';
     } else {
-      return 'library(${getLibraryOrScriptName()})';
+      return 'library(${getLibraryName()})';
     }
   }
 
   int compareTo(LibraryElement other) {
     if (this == other) return 0;
-    return getLibraryOrScriptName().compareTo(other.getLibraryOrScriptName());
+    return getLibraryName().compareTo(other.getLibraryName());

[ahe, 2013/10/10 11:47:53]

All the above should probably continue to use getLibraryOrScriptName.

   }
 }
 
 class PrefixElementX extends ElementX implements PrefixElement {
   Map<SourceString, Element> imported;
   Token firstPosition;
 
   PrefixElementX(SourceString prefix, Element enclosing, this.firstPosition)
       : imported = new Map<SourceString, Element>(),
         super(prefix, ElementKind.PREFIX, enclosing);
@@ skipping 1365 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }