Issue 25277002: Revert r28050 due to crashes with --optimization-counter-threshold=5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25277002: Revert r28050 due to crashes with --optimization-counter-threshold=5. (Closed)

Created:
7 years, 2 months ago by Florian Schneider

Modified:
7 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r28050 due to crashes with --optimization-counter-threshold=5. TBR=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=28052

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -112 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	3 chunks	+10 lines, -68 lines	1 comment	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 manually as r28052 (presubmit successful).

7 years, 2 months ago (2013-09-30 14:29:53 UTC) #2

Florian Schneider

7 years, 2 months ago (2013-09-30 14:58:00 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/25277002/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (left):

https://codereview.chromium.org/25277002/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:6860: while (current->IsEmptyBlock()) {
There is a bug: I need to check for (#predecessors == 1), so that a join of an
empty-block and a non-empty block does not eliminated by mistake.

Expand Messages | Collapse Messages