Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: runtime/vm/compiler.cc

Issue 25277002: Revert r28050 due to crashes with --optimization-counter-threshold=5. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 } 445 }
446 // We have to perform range analysis after LICM because it 446 // We have to perform range analysis after LICM because it
447 // optimistically moves CheckSmi through phis into loop preheaders 447 // optimistically moves CheckSmi through phis into loop preheaders
448 // making some phis smi. 448 // making some phis smi.
449 optimizer.InferSmiRanges(); 449 optimizer.InferSmiRanges();
450 DEBUG_ASSERT(flow_graph->VerifyUseLists()); 450 DEBUG_ASSERT(flow_graph->VerifyUseLists());
451 } 451 }
452 452
453 if (FLAG_constant_propagation) { 453 if (FLAG_constant_propagation) {
454 // Constant propagation can use information from range analysis to 454 // Constant propagation can use information from range analysis to
455 // find unreachable branch targets and eliminate branches that have 455 // find unreachable branch targets.
456 // the same true- and false-target.
457 ConstantPropagator::OptimizeBranches(flow_graph); 456 ConstantPropagator::OptimizeBranches(flow_graph);
458 DEBUG_ASSERT(flow_graph->VerifyUseLists()); 457 DEBUG_ASSERT(flow_graph->VerifyUseLists());
459 } 458 }
460 459
461 if (FLAG_propagate_types) { 460 if (FLAG_propagate_types) {
462 // Recompute types after code movement was done to ensure correct 461 // Recompute types after code movement was done to ensure correct
463 // reaching types for hoisted values. 462 // reaching types for hoisted values.
464 FlowGraphTypePropagator propagator(flow_graph); 463 FlowGraphTypePropagator propagator(flow_graph);
465 propagator.Propagate(); 464 propagator.Propagate();
466 DEBUG_ASSERT(flow_graph->VerifyUseLists()); 465 DEBUG_ASSERT(flow_graph->VerifyUseLists());
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 Object::Handle(isolate->object_store()->sticky_error()); 924 Object::Handle(isolate->object_store()->sticky_error());
926 isolate->object_store()->clear_sticky_error(); 925 isolate->object_store()->clear_sticky_error();
927 isolate->set_long_jump_base(base); 926 isolate->set_long_jump_base(base);
928 return result.raw(); 927 return result.raw();
929 } 928 }
930 UNREACHABLE(); 929 UNREACHABLE();
931 return Object::null(); 930 return Object::null();
932 } 931 }
933 932
934 } // namespace dart 933 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698