Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 25277002: Revert r28050 due to crashes with --optimization-counter-threshold=5. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.h
===================================================================
--- runtime/vm/flow_graph_optimizer.h (revision 28051)
+++ runtime/vm/flow_graph_optimizer.h (working copy)
@@ -248,16 +248,8 @@
static void Optimize(FlowGraph* graph);
- // (1) Visit branches to optimize away unreachable blocks discovered by range
- // analysis.
- // (2) Eliminate branches that have the same true- and false-target: For
- // example, this occurs after expressions like
- //
- // if (a == null || b == null) {
- // ...
- // }
- //
- // where b is known to be null.
+ // Only visit branches to optimize away unreachable blocks discovered
+ // by range analysis.
static void OptimizeBranches(FlowGraph* graph);
// Used to initialize the abstract value of definitions.
@@ -267,7 +259,6 @@
void Analyze();
void VisitBranches();
void Transform();
- void EliminateRedundantBranches();
void SetReachable(BlockEntryInstr* block);
void SetValue(Definition* definition, const Object& value);

Powered by Google App Engine
This is Rietveld 408576698