Translate parts of engine.services project.

Translate parts of engine.services project.

Some tweaks for Java implementations to get valid or better Dart code.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=35466

[Brian Wilkerson, 2014-04-26 17:04:52]

I think the services code should go into a new analysis_services package, not
into the analysis_server package (although I do agree that the similarity
between the names could be a problem).

https://codereview.chromium.org/250823006/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java:271:
} catch (Throwable e) {
Shouldn't we at least log this exception, even if it's only an informational
message?

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:606:
System.out.println("zzzzzzzzz");
Is this debugging code that needs to be deleted?

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java:139:
// XXX
Is this unfinished work, or just a left over marker?

[scheglov, 2014-04-26 18:02:15]

PTAL

https://codereview.chromium.org/250823006/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java:271:
} catch (Throwable e) {
On 2014/04/26 17:04:52, Brian Wilkerson wrote:
> Shouldn't we at least log this exception, even if it's only an informational
> message?

Done.

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:606:
System.out.println("zzzzzzzzz");
On 2014/04/26 17:04:52, Brian Wilkerson wrote:
> Is this debugging code that needs to be deleted?

Done.

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java
(right):

https://codereview.chromium.org/250823006/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java:139:
// XXX
On 2014/04/26 17:04:52, Brian Wilkerson wrote:
> Is this unfinished work, or just a left over marker?

Left over marker.
Removed.

[Brian Wilkerson, 2014-04-26 18:28:17]

LGTM

[scheglov, 2014-04-26 19:01:40]

Committed patchset #2 manually as r35466 (presubmit successful).