Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java

Issue 250823006: Translate parts of engine.services project. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Move to pkg/analysis_services/ Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java
diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java
index 14bf0f4388c4f7676ec2e005c8da045ed0539aa5..6fc6aca358f523a03ffe00ab3d9278c35e230ca3 100644
--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java
+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/change/SourceChange.java
@@ -14,10 +14,11 @@
package com.google.dart.engine.services.change;
-import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.dart.engine.source.Source;
+import com.google.dart.engine.utilities.translation.DartOmit;
+import com.google.dart.engine.utilities.translation.DartOptional;
import java.util.List;
import java.util.Map;
@@ -28,7 +29,7 @@ import java.util.Map;
public class SourceChange extends Change {
private final Source source;
private final List<Edit> edits = Lists.newArrayList();
- private final Map<String, List<Edit>> editGroups = Maps.newTreeMap();
+ private final Map<String, List<Edit>> editGroups = Maps.newHashMap();
/**
* @param name the name of this change to display in UI
@@ -42,15 +43,15 @@ public class SourceChange extends Change {
/**
* Adds the {@link Edit} to apply.
*/
+ @DartOmit
public void addEdit(Edit edit) {
- addEdit("", edit);
+ addEdit(edit, "");
}
/**
* Adds the {@link Edit} to apply.
*/
- public void addEdit(String description, Edit edit) {
- Preconditions.checkNotNull(edit);
+ public void addEdit(Edit edit, @DartOptional(defaultValue = "''") String description) {
// add to all edits
edits.add(edit);
// add to group

Powered by Google App Engine
This is Rietveld 408576698