editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java - Issue 250823006: Translate parts of engine.services project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java

Issue 250823006: Translate parts of engine.services project. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move to pkg/analysis_services/ Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertGetterToMethodRefactoringImpl.java ('k') | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ExtractExpressionAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java

index 783fad951c3098654b87c6cd039853eb6b64e049..dd43958c15870f91242ed4b3764032ffceb583c9 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ConvertMethodToGetterRefactoringImpl.java

@@ -176,12 +176,12 @@ public class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implem

// insert "get "

{

Edit edit = new Edit(element.getNameOffset(), 0, "get ");

- change.addEdit(description, edit);

+ change.addEdit(edit, description);

}

// remove parameters

{

Edit edit = new Edit(rangeNode(parameters), "");

- change.addEdit(description, edit);

+ change.addEdit(edit, description);

}

@@ -202,7 +202,7 @@ public class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implem

if (invocation != null) {

SourceRange range = rangeEndEnd(refRange, invocation);

SourceChange refChange = changeManager.get(reference.source);

- refChange.addEdit("Replace invocation with field access", new Edit(range, ""));

+ refChange.addEdit(new Edit(range, ""), "Replace invocation with field access");

}