Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 24491003: Revert "Revert "Start of dartium custom element lifecycle event support."" (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, siva
Visibility:
Public.

Description

Revert "Revert "Start of dartium custom element lifecycle event support."" Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/. This is dependent on https://codereview.chromium.org/24677002/ First patch is the original, second is the updates. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27921

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -107 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 9 chunks +34 lines, -62 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 6 chunks +25 lines, -34 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 2 months ago (2013-09-25 21:33:55 UTC) #1
vsm
lgtm https://codereview.chromium.org/24491003/diff/3001/tools/dom/templates/html/impl/impl_Document.darttemplate File tools/dom/templates/html/impl/impl_Document.darttemplate (right): https://codereview.chromium.org/24491003/diff/3001/tools/dom/templates/html/impl/impl_Document.darttemplate#newcode47 tools/dom/templates/html/impl/impl_Document.darttemplate:47: } else { Can you add a comment ...
7 years, 2 months ago (2013-09-25 22:27:40 UTC) #2
blois
https://codereview.chromium.org/24491003/diff/3001/tools/dom/templates/html/impl/impl_Document.darttemplate File tools/dom/templates/html/impl/impl_Document.darttemplate (right): https://codereview.chromium.org/24491003/diff/3001/tools/dom/templates/html/impl/impl_Document.darttemplate#newcode47 tools/dom/templates/html/impl/impl_Document.darttemplate:47: } else { On 2013/09/25 22:27:40, vsm wrote: > ...
7 years, 2 months ago (2013-09-25 22:50:43 UTC) #3
blois
7 years, 2 months ago (2013-09-25 23:15:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r27921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698