Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 24661002: Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle This is part of getting custom element lifecycles working in Dart and follows the same model that V8 is using. Basically it ensures that the lifecycle events are processed after any operations which may have custom element side-effects. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/dom/scripts/systemnative.py View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-09-25 20:28:28 UTC) #1
vsm
lgtm
7 years, 2 months ago (2013-09-25 20:29:45 UTC) #2
blois
7 years, 2 months ago (2013-09-25 20:34:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698