Issue 24395014: Address codereview comments:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24395014: Address codereview comments: (Closed)

Created:
7 years, 3 months ago by Ivan Posva

Modified:
7 years, 3 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address codereview comments: - Update variable names. - Add test case for column-free stack frame. Committed: https://code.google.com/p/dart/source/detail?r=27852

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	pkg/stack_trace/lib/src/frame.dart	View		1 chunk	+4 lines, -4 lines	1 comment	Download
	M	pkg/stack_trace/test/frame_test.dart	View		2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r27852 (presubmit successful).

7 years, 3 months ago (2013-09-24 20:54:34 UTC) #2

nweiz

7 years, 3 months ago (2013-09-24 21:45:32 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/24395014/diff/1/pkg/stack_trace/lib/src/frame...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/24395014/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:120: col = int.parse(columnMatch);
This still refers to "col", as does the reference in [new Frame] below.

Expand Messages | Collapse Messages