Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/stack_trace/test/frame_test.dart

Issue 24395014: Address codereview comments: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/stack_trace/lib/src/frame.dart ('K') | « pkg/stack_trace/lib/src/frame.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/test/frame_test.dart
===================================================================
--- pkg/stack_trace/test/frame_test.dart (revision 27833)
+++ pkg/stack_trace/test/frame_test.dart (working copy)
@@ -10,7 +10,7 @@
void main() {
group('.parseVM', () {
- test('parses a stack frame correctly', () {
+ test('parses a stack frame with column correctly', () {
var frame = new Frame.parseVM("#1 Foo._bar "
"(file:///home/nweiz/code/stuff.dart:42:21)");
expect(frame.uri,
@@ -20,6 +20,16 @@
expect(frame.member, equals('Foo._bar'));
});
+ test('parses a stack frame without column correctly', () {
+ var frame = new Frame.parseVM("#1 Foo._bar "
+ "(file:///home/nweiz/code/stuff.dart:24)");
+ expect(frame.uri,
+ equals(Uri.parse("file:///home/nweiz/code/stuff.dart")));
+ expect(frame.line, equals(24));
+ expect(frame.column, null);
+ expect(frame.member, equals('Foo._bar'));
+ });
+
test('converts "<anonymous closure>" to "<fn>"', () {
String parsedMember(String member) =>
new Frame.parseVM('#0 $member (foo:0:0)').member;
« pkg/stack_trace/lib/src/frame.dart ('K') | « pkg/stack_trace/lib/src/frame.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698