Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/stack_trace/lib/src/frame.dart

Issue 24395014: Address codereview comments: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/stack_trace/test/frame_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/lib/src/frame.dart
===================================================================
--- pkg/stack_trace/lib/src/frame.dart (revision 27833)
+++ pkg/stack_trace/lib/src/frame.dart (working copy)
@@ -114,10 +114,10 @@
var member = match[1].replaceAll("<anonymous closure>", "<fn>");
var uri = Uri.parse(match[2]);
var line = int.parse(match[3]);
- var col = null;
- var col_match = match[4];
- if (col_match != null) {
- col = int.parse(col_match);
+ var column = null;
+ var columnMatch = match[4];
+ if (columnMatch != null) {
+ col = int.parse(columnMatch);
nweiz 2013/09/24 21:45:32 This still refers to "col", as does the reference
}
return new Frame(uri, line, col, member);
}
« no previous file with comments | « no previous file | pkg/stack_trace/test/frame_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698