Adds Runtime call stub and Dart entry stub to ARM64.

Adds Runtime call stub and Dart entry stub to ARM64.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35190

[regis, 2014-04-18 22:15:30]

LGTM

Regarding the stack frame layout, it would make sense to move the PC marker on
the other side of the save FP. It would save the pop instruction discarding it
on return.

The reason it was on this side on ARM was due to the multiple register push
instruction.

I suppose it is on the same side on MIPS, because it was ported from ARM.

I am OK with leaving it on this side to keep the port easier. Up to you.

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:642: void AddImmediate(Register dest, Register rn,
int64_t imm, Register pp);
You should explain in a comment what is the purpose of passing pp.
Readers would expect register PP to be used implicitly.
Should PP be the default value of pp?
Also, indicate whether pp must be tagged or not.
No need to repeat the comment for all calls accepting pp explicitly.
A similar comment would also be useful on the X64 side.

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/runtime_entry...
File runtime/vm/runtime_entry_arm64.cc (right):

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/runtime_entry...
runtime/vm/runtime_entry_arm64.cc:30: // in registers (maximum 2 double
arguments for leaf float runtime calls).
Di you verify this comment? The ARM64 ABI may be different from the ARM ABI.

[zra, 2014-04-18 23:24:21]

Thanks!

I rearranged the stack frame to match x64. It doesn't save an instruction in
LeaveDartFrame, yet, but I'll implement an instruction in my next CL that will
save an instruction there.

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:642: void AddImmediate(Register dest, Register rn,
int64_t imm, Register pp);
On 2014/04/18 22:15:30, regis wrote:
> You should explain in a comment what is the purpose of passing pp.
> Readers would expect register PP to be used implicitly.
> Should PP be the default value of pp?
> Also, indicate whether pp must be tagged or not.
> No need to repeat the comment for all calls accepting pp explicitly.
> A similar comment would also be useful on the X64 side.

Done.

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/runtime_entry...
File runtime/vm/runtime_entry_arm64.cc (right):

https://codereview.chromium.org/243773002/diff/40001/runtime/vm/runtime_entry...
runtime/vm/runtime_entry_arm64.cc:30: // in registers (maximum 2 double
arguments for leaf float runtime calls).
On 2014/04/18 22:15:30, regis wrote:
> Di you verify this comment? The ARM64 ABI may be different from the ARM ABI.

The ABI allows 8 register arguments for both integer and floating point. I've
updated to reflect.

[zra, 2014-04-18 23:43:27]

Committed patchset #4 manually as r35190 (presubmit successful).