Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 24126002: Latest attempt to polymer-build scripts in fix windows (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Latest attempt to polymer-build scripts in fix windows R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27457

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -49 lines) Patch
M pkg/pkg.status View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/polymer/lib/src/barback_runner.dart View 6 chunks +23 lines, -39 lines 1 comment Download
M pkg/polymer/lib/src/transform/common.dart View 1 2 chunks +13 lines, -4 lines 1 comment Download
M samples/samples.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/24126002/diff/3001/pkg/polymer/lib/src/transform/common.dart File pkg/polymer/lib/src/transform/common.dart (right): https://codereview.chromium.org/24126002/diff/3001/pkg/polymer/lib/src/transform/common.dart#newcode51 pkg/polymer/lib/src/transform/common.dart:51: if (currentPackage == null || entryPoints == null) { ...
7 years, 3 months ago (2013-09-12 22:11:29 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/24126002/diff/3001/pkg/polymer/lib/src/barback_runner.dart File pkg/polymer/lib/src/barback_runner.dart (right): https://codereview.chromium.org/24126002/diff/3001/pkg/polymer/lib/src/barback_runner.dart#newcode197 pkg/polymer/lib/src/barback_runner.dart:197: if (dir.existsSync()) dir.deleteSync(recursive: true); this other change is also ...
7 years, 3 months ago (2013-09-12 22:18:05 UTC) #2
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-09-12 22:39:50 UTC) #3
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-09-12 22:42:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698