Latest attempt to polymer-build scripts in fix windows

pkg/polymer/lib/src/barback_runner.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Definitions used to run the polymer linter and deploy tools without using
  * pub serve or pub deploy.
  */
 library polymer.src.barback_runner;
 
@@ skipping 112 matching lines @@
 
 /** A simple provider that reads files directly from the pub cache. */
 class _PolymerPackageProvider implements PackageProvider {
   Map<String, String> packageDirs;
   Iterable<String> get packages => packageDirs.keys;
 
   _PolymerPackageProvider(this.packageDirs);
 
   Future<Asset> getAsset(AssetId id) => new Future.value(
       new Asset.fromPath(id, path.join(packageDirs[id.package],
-      // Assets always use the posix style paths
-      path.joinAll(path.posix.split(id.path)))));
+      _toSystemPath(id.path))));
+}
+
+/** Convert asset paths to system paths (Assets always use the posix style). */
+String _toSystemPath(String assetPath) {
+  if (path.Style.platform != path.Style.windows) return assetPath;
+  return path.joinAll(path.posix.split(assetPath));
 }
 
 /** Tell barback which transformers to use and which assets to process. */
 void _initBarback(Barback barback, BarbackOptions options) {
   var assets = [];
   void addAssets(String package, String subDir) {
     for (var filepath in _listPackageDir(package, subDir, options)) {
       assets.add(new AssetId(package, filepath));
     }
   }
@@ skipping 35 matching lines @@
     }
   });
 }
 
 /**
  * Emits all outputs of [barback] and copies files that we didn't process (like
  * polymer's libraries).
  */
 Future _emitAllFiles(Barback barback, BarbackOptions options) {
   return barback.getAllAssets().then((assets) {
+    // Delete existing output folder before we generate anything
+    var dir = new Directory(options.outDir);
+    if (dir.existsSync()) dir.deleteSync(recursive: true);

[Siggi Cherem (dart-lang), 2013/09/12 22:18:05]

this other change is also unnecessary, but I think it makes things simpler: this
deletes and recreates the output folder, instead of  just deleting individual
'packages' directories.

     return _emitPackagesDir(options)
       .then((_) => _emitTransformedFiles(assets, options))
       .then((_) => _addPackagesSymlinks(assets, options))
       .then((_) => assets);
   });
 }
 
 Future _emitTransformedFiles(AssetSet assets, BarbackOptions options) {
   // Copy all the assets we transformed
   var futures = [];
   var currentPackage = options.currentPackage;
   var transformTests = options.transformTests;
   var outPackages = path.join(options.outDir, 'packages');
   for (var asset in assets) {
     var id = asset.id;
     var dir = _firstDir(id.path);
     if (dir == null) continue;
 
     var filepath;
     if (dir == 'lib') {
       // Put lib files directly under the packages folder (e.g. 'lib/foo.dart'
       // will be emitted at out/packages/package_name/foo.dart).
-      filepath = path.join(outPackages, id.package, id.path.substring(4));
+      filepath = path.join(outPackages, id.package,
+          _toSystemPath(id.path.substring(4)));
     } else if (id.package == currentPackage &&
         (dir == 'web' || (transformTests && dir == 'test'))) {
-      filepath = path.join(options.outDir, id.path);
+      filepath = path.join(options.outDir, _toSystemPath(id.path));
     } else {
       // TODO(sigmund): do something about other assets?
       continue;
     }
 
     futures.add(_writeAsset(filepath, asset));
   }
   return Future.wait(futures);
 }
 
 /**
  * Adds a package symlink from each directory under `out/web/foo/` to
  * `out/packages`.
  */
 Future _addPackagesSymlinks(AssetSet assets, BarbackOptions options) {
   var outPackages = path.join(options.outDir, 'packages');
   var currentPackage = options.currentPackage;
   for (var asset in assets) {
     var id = asset.id;
     if (id.package != currentPackage) continue;
     var firstDir = _firstDir(id.path);
     if (firstDir == null) continue;
 
     if (firstDir == 'web' || (options.transformTests && firstDir == 'test')) {
-      var dir = path.join(options.outDir, path.dirname(id.path));
+      var dir = path.join(options.outDir, path.dirname(_toSystemPath(id.path)));
       var linkPath = path.join(dir, 'packages');
-      _deleteIfPresent(linkPath);
-      var targetPath = Platform.operatingSystem == 'windows'
-          ? path.normalize(path.absolute(outPackages))
-          : path.normalize(path.relative(outPackages, from: dir));
-      new Link(linkPath).createSync(targetPath);
+      var link = new Link(linkPath);
+      if (!link.existsSync()) {
+        var targetPath = Platform.operatingSystem == 'windows'
+            ? path.normalize(path.absolute(outPackages))
+            : path.normalize(path.relative(outPackages, from: dir));
+        link.createSync(targetPath);
+      }
     }
   }
 }
 
 /**
  * Emits a 'packages' directory directly under `out/packages` with the contents
  * of every file that was not transformed by barback.
  */
 Future _emitPackagesDir(BarbackOptions options) {
-  // Ensure we don't have a packages symlink in our output folder (could happen
-  // when people are using nested packages).
+  if (options.transformPolymerDependencies) return new Future.value(null);
   var outPackages = path.join(options.outDir, 'packages');
-  _deleteIfPresent(outPackages);
-
-  if (options.transformPolymerDependencies) return new Future.value(null);
+  _ensureDir(outPackages);
 
   // Copy all the files we didn't process
   var futures = [];
   var dirs = options.packageDirs;
   for (var package in _polymerPackageDependencies) {
     for (var relpath in _listPackageDir(package, 'lib', options)) {
       var inpath = path.join(dirs[package], relpath);
       var outpath = path.join(outPackages, package, relpath.substring(4));
       futures.add(_copyFile(inpath, outpath));
     }
   }
   return Future.wait(futures);
 }
 
 /** Ensure [dirpath] exists. */
 void _ensureDir(String dirpath) {
   new Directory(dirpath).createSync(recursive: true);
 }
 
-/** Deletes [packagesPath] if it's a packages symlink, file, or folder. */
-void _deleteIfPresent(String packagesPath) {
-  try {
-    var link = new Link(packagesPath);
-    if (link.existsSync()) {
-      link.deleteSync();
-      return;
-    }
-
-    var dir = new Directory(packagesPath);
-    if (dir.existsSync()) {
-      dir.deleteSync(recursive: true);
-      return;
-    }
-
-    var file = new File(packagesPath);
-    if (file.existsSync()) {
-      file.deleteSync();
-    }
-  } catch (e) {
-    print('Error while deleting $pacakgesPath: $e');
-  }
-}
-
 /**
  * Returns the first directory name on a url-style path, or null if there are no
  * slashes.
  */
 String _firstDir(String url) {
   var firstSlash = url.indexOf('/');
   if (firstSlash == -1) return null;
   return url.substring(0, firstSlash);
 }
 
 /** Copy a file from [inpath] to [outpath]. */
 Future _copyFile(String inpath, String outpath) {
   _ensureDir(path.dirname(outpath));
   var writer = new File(outpath).openWrite();
   return writer.addStream(new File(inpath).openRead())
       .then((_) => writer.close());
 }
 
 /** Write contents of an [asset] into a file at [filepath]. */
 Future _writeAsset(String filepath, Asset asset) {
   _ensureDir(path.dirname(filepath));
   var writer = new File(filepath).openWrite();
   return writer.addStream(asset.read()).then((_) => writer.close());
 }