Latest attempt to polymer-build scripts in fix windows

pkg/polymer/lib/src/barback_runner.dart

Index: pkg/polymer/lib/src/barback_runner.dart
diff --git a/pkg/polymer/lib/src/barback_runner.dart b/pkg/polymer/lib/src/barback_runner.dart
index eaf637b27cc90d39aa60d3360bf2908a51de7cee..c6b02f0832d5eae9236448350936dd9370307736 100644
--- a/pkg/polymer/lib/src/barback_runner.dart
+++ b/pkg/polymer/lib/src/barback_runner.dart
@@ -130,8 +130,13 @@ class _PolymerPackageProvider implements PackageProvider {
 
   Future<Asset> getAsset(AssetId id) => new Future.value(
       new Asset.fromPath(id, path.join(packageDirs[id.package],
-      // Assets always use the posix style paths
-      path.joinAll(path.posix.split(id.path)))));
+      _toSystemPath(id.path))));
+}
+
+/** Convert asset paths to system paths (Assets always use the posix style). */
+String _toSystemPath(String assetPath) {
+  if (path.Style.platform != path.Style.windows) return assetPath;
+  return path.joinAll(path.posix.split(assetPath));
 }
 
 /** Tell barback which transformers to use and which assets to process. */
@@ -187,6 +192,9 @@ void _attachListeners(Barback barback) {
  */
 Future _emitAllFiles(Barback barback, BarbackOptions options) {
   return barback.getAllAssets().then((assets) {
+    // Delete existing output folder before we generate anything
+    var dir = new Directory(options.outDir);
+    if (dir.existsSync()) dir.deleteSync(recursive: true);

[Siggi Cherem (dart-lang), 2013/09/12 22:18:05]

this other change is also unnecessary, but I think it makes things simpler: this
deletes and recreates the output folder, instead of  just deleting individual
'packages' directories.

     return _emitPackagesDir(options)
       .then((_) => _emitTransformedFiles(assets, options))
       .then((_) => _addPackagesSymlinks(assets, options))
@@ -209,10 +217,11 @@ Future _emitTransformedFiles(AssetSet assets, BarbackOptions options) {
     if (dir == 'lib') {
       // Put lib files directly under the packages folder (e.g. 'lib/foo.dart'
       // will be emitted at out/packages/package_name/foo.dart).
-      filepath = path.join(outPackages, id.package, id.path.substring(4));
+      filepath = path.join(outPackages, id.package,
+          _toSystemPath(id.path.substring(4)));
     } else if (id.package == currentPackage &&
         (dir == 'web' || (transformTests && dir == 'test'))) {
-      filepath = path.join(options.outDir, id.path);
+      filepath = path.join(options.outDir, _toSystemPath(id.path));
     } else {
       // TODO(sigmund): do something about other assets?
       continue;
@@ -237,13 +246,15 @@ Future _addPackagesSymlinks(AssetSet assets, BarbackOptions options) {
     if (firstDir == null) continue;
 
     if (firstDir == 'web' || (options.transformTests && firstDir == 'test')) {
-      var dir = path.join(options.outDir, path.dirname(id.path));
+      var dir = path.join(options.outDir, path.dirname(_toSystemPath(id.path)));
       var linkPath = path.join(dir, 'packages');
-      _deleteIfPresent(linkPath);
-      var targetPath = Platform.operatingSystem == 'windows'
-          ? path.normalize(path.absolute(outPackages))
-          : path.normalize(path.relative(outPackages, from: dir));
-      new Link(linkPath).createSync(targetPath);
+      var link = new Link(linkPath);
+      if (!link.existsSync()) {
+        var targetPath = Platform.operatingSystem == 'windows'
+            ? path.normalize(path.absolute(outPackages))
+            : path.normalize(path.relative(outPackages, from: dir));
+        link.createSync(targetPath);
+      }
     }
   }
 }
@@ -253,12 +264,9 @@ Future _addPackagesSymlinks(AssetSet assets, BarbackOptions options) {
  * of every file that was not transformed by barback.
  */
 Future _emitPackagesDir(BarbackOptions options) {
-  // Ensure we don't have a packages symlink in our output folder (could happen
-  // when people are using nested packages).
-  var outPackages = path.join(options.outDir, 'packages');
-  _deleteIfPresent(outPackages);
-
   if (options.transformPolymerDependencies) return new Future.value(null);
+  var outPackages = path.join(options.outDir, 'packages');
+  _ensureDir(outPackages);
 
   // Copy all the files we didn't process
   var futures = [];
@@ -278,30 +286,6 @@ void _ensureDir(String dirpath) {
   new Directory(dirpath).createSync(recursive: true);
 }
 
-/** Deletes [packagesPath] if it's a packages symlink, file, or folder. */
-void _deleteIfPresent(String packagesPath) {
-  try {
-    var link = new Link(packagesPath);
-    if (link.existsSync()) {
-      link.deleteSync();
-      return;
-    }
-
-    var dir = new Directory(packagesPath);
-    if (dir.existsSync()) {
-      dir.deleteSync(recursive: true);
-      return;
-    }
-
-    var file = new File(packagesPath);
-    if (file.existsSync()) {
-      file.deleteSync();
-    }
-  } catch (e) {
-    print('Error while deleting $pacakgesPath: $e');
-  }
-}
-
 /**
  * Returns the first directory name on a url-style path, or null if there are no
  * slashes.