java2dart improvement - use field if getter/setter are trivial.

java2dart improvement - use field if getter/setter are trivial.

Also analyzer_experimental snapshot.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=27138

[Brian Wilkerson, 2013-09-04 16:48:59]

LGTM. I didn't look at all of the changes in the generated code, but I did look
at some of them; I'm hoping our tests will catch any problems there.

https://codereview.chromium.org/23769004/diff/1/editor/util/plugins/com.googl...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java
(right):

https://codereview.chromium.org/23769004/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java:185:
unit.accept(new GeneralizingASTVisitor<Void>() {
It's a minor point, but if you're only invoking methods defined on ASTVisitor it
will be faster to use RecursiveASTVisitor.

https://codereview.chromium.org/23769004/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java:237:
readOnly &= reference.inGetterContext();
Given that getter and setter contexts are not mutually exclusive, I think this
needs to be !reference.inSetterContext().

[scheglov, 2013-09-04 19:17:48]

Committed patchset #1 manually as r27138 (presubmit successful).