java2dart improvement - use field if getter/setter are trivial.

pkg/analyzer_experimental/lib/src/generated/source_io.dart

 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 library engine.source.io;
 import 'source.dart';
 import 'java_core.dart';
 import 'java_io.dart';
 import 'engine.dart' show AnalysisContext, AnalysisEngine;
 export 'source.dart';
 /**
  * Instances of the class `FileBasedSource` implement a source that represents a file.
  *
  * @coverage dart.engine.source
  */
 class FileBasedSource implements Source {
 
   /**
    * The content cache used to access the contents of this source if they have been overridden from
    * what is on disk or cached.
    */
   ContentCache _contentCache;
 
   /**
    * The file represented by this source.
    */
-  JavaFile _file;
+  JavaFile file;
 
   /**
    * The cached encoding for this source.
    */
   String _encoding;
 
   /**
    * The kind of URI from which this source was originally derived.
    */
   UriKind _uriKind;
 
   /**
    * Initialize a newly created source object. The source object is assumed to not be in a system
    * library.
    *
    * @param contentCache the content cache used to access the contents of this source
    * @param file the file represented by this source
    */
   FileBasedSource.con1(ContentCache contentCache, JavaFile file) : this.con2(contentCache, file, UriKind.FILE_URI);
 
   /**
    * Initialize a newly created source object.
    *
    * @param contentCache the content cache used to access the contents of this source
    * @param file the file represented by this source
    * @param flags `true` if this source is in one of the system libraries
    */
   FileBasedSource.con2(ContentCache contentCache, JavaFile file, UriKind uriKind) {
     this._contentCache = contentCache;
-    this._file = file;
+    this.file = file;
     this._uriKind = uriKind;
     if (file.getPath().indexOf(':') > 2) {
       try {
         throw new IllegalArgumentException("Invalid source path: ${file}");
       } on IllegalArgumentException catch (e) {
         AnalysisEngine.instance.logger.logError3(e);
         throw e;
       }
     }
   }
-  bool operator ==(Object object) => object != null && this.runtimeType == object.runtimeType && _file == ((object as FileBasedSource))._file;
-  bool exists() => _contentCache.getContents(this) != null || (_file.exists() && !_file.isDirectory());
+  bool operator ==(Object object) => object != null && this.runtimeType == object.runtimeType && file == ((object as FileBasedSource)).file;
+  bool exists() => _contentCache.getContents(this) != null || (file.exists() && !file.isDirectory());
   void getContents(Source_ContentReceiver receiver) {
     {
       String contents = _contentCache.getContents(this);
       if (contents != null) {
         receiver.accept2(contents, _contentCache.getModificationStamp(this));
         return;
       }
     }
-    receiver.accept2(_file.readAsStringSync(), _file.lastModified());
+    receiver.accept2(file.readAsStringSync(), file.lastModified());
   }
   String get encoding {
     if (_encoding == null) {
-      _encoding = "${_uriKind.encoding}${_file.toURI().toString()}";
+      _encoding = "${_uriKind.encoding}${file.toURI().toString()}";
     }
     return _encoding;
   }
-  String get fullName => _file.getAbsolutePath();
+  String get fullName => file.getAbsolutePath();
   int get modificationStamp {
     int stamp = _contentCache.getModificationStamp(this);
     if (stamp != null) {
       return stamp;
     }
-    return _file.lastModified();
+    return file.lastModified();
   }
-  String get shortName => _file.getName();
+  String get shortName => file.getName();
   UriKind get uriKind => _uriKind;
-  int get hashCode => _file.hashCode;
+  int get hashCode => file.hashCode;
   bool get isInSystemLibrary => identical(_uriKind, UriKind.DART_URI);
   Source resolveRelative(Uri containedUri) {
     try {
       Uri resolvedUri = file.toURI().resolveUri(containedUri);
       return new FileBasedSource.con2(_contentCache, new JavaFile.fromUri(resolvedUri), _uriKind);
     } catch (exception) {
     }
     return null;
   }
   String toString() {
-    if (_file == null) {
+    if (file == null) {
       return "<unknown source>";
     }
-    return _file.getAbsolutePath();
+    return file.getAbsolutePath();
   }
-
-  /**
-   * Return the file represented by this source. This is an internal method that is only intended to
-   * be used by [UriResolver].
-   *
-   * @return the file represented by this source
-   */
-  JavaFile get file => _file;
 }
 /**
  * Instances of the class `PackageUriResolver` resolve `package` URI's in the context of
  * an application.
  *
  * For the purposes of sharing analysis, the path to each package under the "packages" directory
  * should be canonicalized, but to preserve relative links within a package, the remainder of the
  * path from the package directory to the leaf should not.
  *
  * @coverage dart.engine.source
@@ skipping 137 matching lines @@
   static String appendFileSeparator(String path) {
     if (path == null || path.length <= 0 || path.codeUnitAt(path.length - 1) == JavaFile.separatorChar) {
       return path;
     }
     return "${path}${JavaFile.separator}";
   }
 
   /**
    * The container's path (not `null`).
    */
-  String _path;
+  String path;
 
   /**
    * Construct a container representing the specified directory and containing any sources whose
    * [Source#getFullName] starts with the directory's path. This is a convenience method,
    * fully equivalent to [DirectoryBasedSourceContainer#DirectoryBasedSourceContainer]
    * .
    *
    * @param directory the directory (not `null`)
    */
   DirectoryBasedSourceContainer.con1(JavaFile directory) : this.con2(directory.getPath());
 
   /**
    * Construct a container representing the specified path and containing any sources whose
    * [Source#getFullName] starts with the specified path.
    *
    * @param path the path (not `null` and not empty)
    */
   DirectoryBasedSourceContainer.con2(String path) {
-    this._path = appendFileSeparator(path);
+    this.path = appendFileSeparator(path);
   }
-  bool contains(Source source) => source.fullName.startsWith(_path);
+  bool contains(Source source) => source.fullName.startsWith(path);
   bool operator ==(Object obj) => (obj is DirectoryBasedSourceContainer) && ((obj as DirectoryBasedSourceContainer)).path == path;
-
-  /**
-   * Answer the receiver's path, used to determine if a source is contained in the receiver.
-   *
-   * @return the path (not `null`, not empty)
-   */
-  String get path => _path;
-  int get hashCode => _path.hashCode;
-  String toString() => "SourceContainer[${_path}]";
+  int get hashCode => path.hashCode;
+  String toString() => "SourceContainer[${path}]";
 }
 /**
  * Instances of the class `FileUriResolver` resolve `file` URI's.
  *
  * @coverage dart.engine.source
  */
 class FileUriResolver extends UriResolver {
 
   /**
    * The name of the `file` scheme.
@@ skipping 13 matching lines @@
     }
     return null;
   }
   Source resolveAbsolute(ContentCache contentCache, Uri uri) {
     if (!isFileUri(uri)) {
       return null;
     }
     return new FileBasedSource.con1(contentCache, new JavaFile.fromUri(uri));
   }
 }