java2dart improvement - use field if getter/setter are trivial.

editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
@@ skipping 602 matching lines @@
 
   /**
    * @return all references (actual references and declarations)
    */
   public List<SimpleIdentifier> getReferences(SimpleIdentifier target) {
     Object binding = nodeToBinding.get(target);
     List<SimpleIdentifier> references = bindingToIdentifiers.get(binding);
     return references != null ? references : Lists.<SimpleIdentifier> newArrayList();
   }
 
+  /**
+   * Remembers that "identifier" is reference to the given Java binding.
+   */
+  public void putReference(SimpleIdentifier identifier, IBinding binding, String bindingSignature) {
+    if (binding != null) {
+      signatureToBinding.put(bindingSignature, binding);
+      identifierToName.put(identifier, identifier.getName());
+      // remember binding for reference
+      nodeToBinding.put(identifier, binding);
+      // add reference to binding
+      List<SimpleIdentifier> identifiers = bindingToIdentifiers.get(binding);
+      if (identifiers == null) {
+        identifiers = Lists.newLinkedList();
+        bindingToIdentifiers.put(binding, identifiers);
+      }
+      identifiers.add(identifier);
+    }
+    // remember global name
+    usedNames.add(identifier.getName());
+  }
+
   public void renameConstructor(ConstructorDeclaration node, String name) {
     IMethodBinding binding = constructorToBinding.get(node);
     //
     SimpleIdentifier newIdentifier;
     if (name == null) {
       newIdentifier = null;
     } else {
       newIdentifier = identifier(name);
     }
     // rename constructor
@@ skipping 133 matching lines @@
     nodeToTypeBinding.put(node, binding);
   }
 
   /**
    * Remembers that given {@link ClassMember} was created for private Java element.
    */
   void putPrivateClassMember(ClassMember member) {
     privateClassMembers.add(member);
   }
 
-  /**
-   * Remembers that "identifier" is reference to the given Java binding.
-   */
-  void putReference(SimpleIdentifier identifier, IBinding binding, String bindingSignature) {
-    if (binding != null) {
-      signatureToBinding.put(bindingSignature, binding);
-      identifierToName.put(identifier, identifier.getName());
-      // remember binding for reference
-      nodeToBinding.put(identifier, binding);
-      // add reference to binding
-      List<SimpleIdentifier> identifiers = bindingToIdentifiers.get(binding);
-      if (identifiers == null) {
-        identifiers = Lists.newLinkedList();
-        bindingToIdentifiers.put(binding, identifiers);
-      }
-      identifiers.add(identifier);
-    }
-    // remember global name
-    usedNames.add(identifier.getName());
-  }
-
   private void dontUseThisInFieldInitializers(CompilationUnit unit) {
     unit.accept(new RecursiveASTVisitor<Void>() {
       @Override
       public Void visitClassDeclaration(ClassDeclaration node) {
         processClass(node);
         return super.visitClassDeclaration(node);
       }
 
       private void addAssignmentsToBlock(Block block, Map<SimpleIdentifier, Expression> initializers) {
         int index = 0;
@@ skipping 309 matching lines @@
                   }
                 }
               }
             }
           }
         }
       }
     });
   }
 }