Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 23672011: Fix the previously ineffective assert checking the number of arguments passed to (Closed)

Created:
7 years, 3 months ago by regis
Modified:
7 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)
Visibility:
Public.

Description

Fix the previously ineffective assert checking the number of arguments passed to a runtime entry in the VM. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26826

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -184 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_mips.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_x64.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 4 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 4 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 10 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 10 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 10 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 10 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M runtime/vm/runtime_entry_ia32.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download
M runtime/vm/runtime_entry_mips.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M runtime/vm/runtime_entry_x64.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 28 chunks +29 lines, -29 lines 0 comments Download
M runtime/vm/stub_code_arm_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 29 chunks +30 lines, -30 lines 0 comments Download
M runtime/vm/stub_code_ia32_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 28 chunks +29 lines, -29 lines 0 comments Download
M runtime/vm/stub_code_mips_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 29 chunks +30 lines, -30 lines 0 comments Download
M runtime/vm/stub_code_x64_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 3 months ago (2013-08-28 22:04:48 UTC) #1
siva
LGTM (as discussed offline we could move the assertion inside the macro in another CL).
7 years, 3 months ago (2013-08-28 22:52:19 UTC) #2
regis
On 2013/08/28 22:52:19, siva wrote: > LGTM > > (as discussed offline we could move ...
7 years, 3 months ago (2013-08-28 22:55:30 UTC) #3
regis
7 years, 3 months ago (2013-08-28 23:07:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698