runtime/vm/stub_code_ia32_test.cc - Issue 23672011: Fix the previously ineffective assert checking the number of arguments passed to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32_test.cc

Issue 23672011: Fix the previously ineffective assert checking the number of arguments passed to (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32_test.cc

===================================================================

--- runtime/vm/stub_code_ia32_test.cc (revision 26825)

+++ runtime/vm/stub_code_ia32_test.cc (working copy)

@@ -51,7 +51,7 @@

__ PushObject(smi1); // Push argument 1 smi1.

__ PushObject(smi2); // Push argument 2 smi2.

ASSERT(kTestSmiSubRuntimeEntry.argument_count() == argc);

- __ CallRuntime(kTestSmiSubRuntimeEntry); // Call SmiSub runtime func.

+ __ CallRuntime(kTestSmiSubRuntimeEntry, argc); // Call SmiSub runtime func.

__ AddImmediate(ESP, Immediate(argc * kWordSize));

__ popl(EAX); // Pop return value from return slot.

__ leave();

@@ -88,7 +88,7 @@

__ movl(Address(ESP, 0), EAX); // Push argument 1 smi1.

__ LoadObject(EAX, smi2);

__ movl(Address(ESP, kWordSize), EAX); // Push argument 2 smi2.

- __ CallRuntime(kTestLeafSmiAddRuntimeEntry); // Call SmiAdd runtime func.

+ __ CallRuntime(kTestLeafSmiAddRuntimeEntry, 2); // Call SmiAdd runtime func.

__ leave();

__ ret(); // Return value is in EAX.

}

« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »