Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: runtime/vm/stub_code_ia32_test.cc

Issue 23672011: Fix the previously ineffective assert checking the number of arguments passed to (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/native_entry.h" 10 #include "vm/native_entry.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2)); 44 const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2));
45 const Object& result = Object::ZoneHandle(); 45 const Object& result = Object::ZoneHandle();
46 const Context& context = Context::ZoneHandle(Context::New(0, Heap::kOld)); 46 const Context& context = Context::ZoneHandle(Context::New(0, Heap::kOld));
47 ASSERT(context.isolate() == Isolate::Current()); 47 ASSERT(context.isolate() == Isolate::Current());
48 __ enter(Immediate(0)); 48 __ enter(Immediate(0));
49 __ LoadObject(CTX, context); 49 __ LoadObject(CTX, context);
50 __ PushObject(result); // Push Null object for return value. 50 __ PushObject(result); // Push Null object for return value.
51 __ PushObject(smi1); // Push argument 1 smi1. 51 __ PushObject(smi1); // Push argument 1 smi1.
52 __ PushObject(smi2); // Push argument 2 smi2. 52 __ PushObject(smi2); // Push argument 2 smi2.
53 ASSERT(kTestSmiSubRuntimeEntry.argument_count() == argc); 53 ASSERT(kTestSmiSubRuntimeEntry.argument_count() == argc);
54 __ CallRuntime(kTestSmiSubRuntimeEntry); // Call SmiSub runtime func. 54 __ CallRuntime(kTestSmiSubRuntimeEntry, argc); // Call SmiSub runtime func.
55 __ AddImmediate(ESP, Immediate(argc * kWordSize)); 55 __ AddImmediate(ESP, Immediate(argc * kWordSize));
56 __ popl(EAX); // Pop return value from return slot. 56 __ popl(EAX); // Pop return value from return slot.
57 __ leave(); 57 __ leave();
58 __ ret(); 58 __ ret();
59 } 59 }
60 60
61 61
62 TEST_CASE(CallRuntimeStubCode) { 62 TEST_CASE(CallRuntimeStubCode) {
63 extern const Function& RegisterFakeFunction(const char* name, 63 extern const Function& RegisterFakeFunction(const char* name,
64 const Code& code); 64 const Code& code);
(...skipping 16 matching lines...) Expand all
81 int value1, 81 int value1,
82 int value2) { 82 int value2) {
83 const Smi& smi1 = Smi::ZoneHandle(Smi::New(value1)); 83 const Smi& smi1 = Smi::ZoneHandle(Smi::New(value1));
84 const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2)); 84 const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2));
85 __ enter(Immediate(0)); 85 __ enter(Immediate(0));
86 __ ReserveAlignedFrameSpace(2 * kWordSize); 86 __ ReserveAlignedFrameSpace(2 * kWordSize);
87 __ LoadObject(EAX, smi1); 87 __ LoadObject(EAX, smi1);
88 __ movl(Address(ESP, 0), EAX); // Push argument 1 smi1. 88 __ movl(Address(ESP, 0), EAX); // Push argument 1 smi1.
89 __ LoadObject(EAX, smi2); 89 __ LoadObject(EAX, smi2);
90 __ movl(Address(ESP, kWordSize), EAX); // Push argument 2 smi2. 90 __ movl(Address(ESP, kWordSize), EAX); // Push argument 2 smi2.
91 __ CallRuntime(kTestLeafSmiAddRuntimeEntry); // Call SmiAdd runtime func. 91 __ CallRuntime(kTestLeafSmiAddRuntimeEntry, 2); // Call SmiAdd runtime func.
92 __ leave(); 92 __ leave();
93 __ ret(); // Return value is in EAX. 93 __ ret(); // Return value is in EAX.
94 } 94 }
95 95
96 96
97 TEST_CASE(CallLeafRuntimeStubCode) { 97 TEST_CASE(CallLeafRuntimeStubCode) {
98 extern const Function& RegisterFakeFunction(const char* name, 98 extern const Function& RegisterFakeFunction(const char* name,
99 const Code& code); 99 const Code& code);
100 const int value1 = 10; 100 const int value1 = 10;
101 const int value2 = 20; 101 const int value2 = 20;
102 const char* kName = "Test_CallLeafRuntimeStubCode"; 102 const char* kName = "Test_CallLeafRuntimeStubCode";
103 Assembler _assembler_; 103 Assembler _assembler_;
104 GenerateCallToCallLeafRuntimeStub(&_assembler_, value1, value2); 104 GenerateCallToCallLeafRuntimeStub(&_assembler_, value1, value2);
105 const Code& code = Code::Handle(Code::FinalizeCode( 105 const Code& code = Code::Handle(Code::FinalizeCode(
106 *CreateFunction("Test_CallLeafRuntimeStubCode"), &_assembler_)); 106 *CreateFunction("Test_CallLeafRuntimeStubCode"), &_assembler_));
107 const Function& function = RegisterFakeFunction(kName, code); 107 const Function& function = RegisterFakeFunction(kName, code);
108 Smi& result = Smi::Handle(); 108 Smi& result = Smi::Handle();
109 result ^= DartEntry::InvokeFunction(function, Object::empty_array()); 109 result ^= DartEntry::InvokeFunction(function, Object::empty_array());
110 EXPECT_EQ((value1 + value2), result.Value()); 110 EXPECT_EQ((value1 + value2), result.Value());
111 } 111 }
112 112
113 } // namespace dart 113 } // namespace dart
114 114
115 #endif // defined TARGET_ARCH_IA32 115 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698