Issue 23567006: Revert "Basic functionality is working with JS native support and polyfill, still some issues with …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23567006: Revert "Basic functionality is working with JS native support and polyfill, still some issues with … (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking." This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=26938

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+243 lines, -618 lines)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View	9 chunks	+61 lines, -87 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	6 chunks	+11 lines, -123 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+7 lines, -74 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View	2 chunks	+147 lines, -205 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	2 chunks	+3 lines, -37 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	3 chunks	+8 lines, -18 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View	1 chunk	+4 lines, -72 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r26938 (presubmit successful).

7 years, 3 months ago (2013-08-30 19:37:29 UTC) #1

Message was sent while issue was closed.

sadness! lgtm

Expand Messages | Collapse Messages