Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 23567006: Revert "Basic functionality is working with JS native support and polyfill, still some issues with … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 5468945b736510af076503ebc6842675554ff62b..02bcaea027a7e2681938de7d52d861988f0fc78a 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -9391,8 +9391,8 @@ abstract class Element extends Node implements ParentNode, ChildNode {
*
* * [isTagSupported]
*/
- factory Element.tag(String tag, [String typeExtention]) =>
- _ElementFactoryProvider.createElement_tag(tag, typeExtention);
+ factory Element.tag(String tag) =>
+ _ElementFactoryProvider.createElement_tag(tag);
/// Creates a new `<a>` element.
///
@@ -9709,7 +9709,7 @@ abstract class Element extends Node implements ParentNode, ChildNode {
* The tag should be a valid HTML tag name.
*/
static bool isTagSupported(String tag) {
- var e = _ElementFactoryProvider.createElement_tag(tag, null);
+ var e = _ElementFactoryProvider.createElement_tag(tag);
return e is Element && !(e is UnknownElement);
}
@@ -10982,8 +10982,8 @@ abstract class Element extends Node implements ParentNode, ChildNode {
class _ElementFactoryProvider {
@DomName('Document.createElement')
- static Element createElement_tag(String tag, String typeExtension) =>
- document.$dom_createElement(tag, typeExtension);
+ static Element createElement_tag(String tag) =>
+ document.$dom_createElement(tag);
}
@@ -13227,75 +13227,8 @@ class HtmlDocument extends Document {
String get visibilityState => _webkitVisibilityState;
@Experimental
- /**
- * Register a custom subclass of Element to be instantiatable by the DOM.
- *
- * This is necessary to allow the construction of any custom elements.
- *
- * The class being registered must either subclass HtmlElement or SvgElement.
- * If they subclass these directly then they can be used as:
- *
- * class FooElement extends HtmlElement{
- * void created() {
- * print('FooElement created!');
- * }
- * }
- *
- * main() {
- * document.register('x-foo', FooElement);
- * var myFoo = new Element.tag('x-foo');
- * // prints 'FooElement created!' to the console.
- * }
- *
- * The custom element can also be instantiated via HTML using the syntax
- * `<x-foo></x-foo>`
- *
- * Other elements can be subclassed as well:
- *
- * class BarElement extends InputElement{
- * void created() {
- * print('BarElement created!');
- * }
- * }
- *
- * main() {
- * document.register('x-bar', BarElement);
- * var myBar = new Element.tag('input', 'x-bar');
- * // prints 'BarElement created!' to the console.
- * }
- *
- * This custom element can also be instantiated via HTML using the syntax
- * `<input is="x-bar"></input>`
- *
- * The [nativeTagName] parameter is needed by platforms without native support
- * when subclassing a native type other than:
- *
- * * HtmlElement
- * * SvgElement
- * * AnchorElement
- * * AudioElement
- * * ButtonElement
- * * CanvasElement
- * * DivElement
- * * ImageElement
- * * InputElement
- * * LIElement
- * * LabelElement
- * * MenuElement
- * * MeterElement
- * * OListElement
- * * OptionElement
- * * OutputElement
- * * ParagraphElement
- * * PreElement
- * * ProgressElement
- * * SelectElement
- * * SpanElement
- * * UListElement
- * * VideoElement
- */
- void register(String tag, Type customElementClass, {String nativeTagName}) {
- _Utils.register(tag, customElementClass);
+ void register(String tag, Type custom) {
+ _Utils.register(tag, custom);
}
// Note: used to polyfill <template>
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/custom/document_register_type_extensions_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698