Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 23567006: Revert "Basic functionality is working with JS native support and polyfill, still some issues with … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 766cf144484473543629c52da2fed13ef0830277..0bf8034edb2ed7c456a3a52e394604548c795982 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -354,8 +354,8 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
*
* * [isTagSupported]
*/
- factory $CLASSNAME.tag(String tag, [String typeExtention]) =>
- _$(CLASSNAME)FactoryProvider.createElement_tag(tag, typeExtention);
+ factory $CLASSNAME.tag(String tag) =>
+ _$(CLASSNAME)FactoryProvider.createElement_tag(tag);
/// Creates a new `<a>` element.
///
@@ -672,7 +672,7 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
* The tag should be a valid HTML tag name.
*/
static bool isTagSupported(String tag) {
- var e = _ElementFactoryProvider.createElement_tag(tag, null);
+ var e = _ElementFactoryProvider.createElement_tag(tag);
return e is Element && !(e is UnknownElement);
}
@@ -1315,22 +1315,12 @@ class _ElementFactoryProvider {
$if DART2JS
// Optimization to improve performance until the dart2js compiler inlines this
// method.
- static dynamic createElement_tag(String tag, String typeExtension) {
- // Firefox may return a JS function for some types (Embed, Object).
- if (typeExtension != null) {
- return JS('Element|=Object', 'document.createElement(#, #)',
- tag, typeExtension);
- }
- // Should be able to eliminate this and just call the two-arg version above
- // with null typeExtension, but Chrome treats the tag as case-sensitive if
- // typeExtension is null.
- // https://code.google.com/p/chromium/issues/detail?id=282467
- return JS('Element|=Object', 'document.createElement(#)', tag);
- }
-
+ static dynamic createElement_tag(String tag) =>
+ // Firefox may return a JS function for some types (Embed, Object).
+ JS('Element|=Object', 'document.createElement(#)', tag);
$else
- static Element createElement_tag(String tag, String typeExtension) =>
- document.$dom_createElement(tag, typeExtension);
+ static Element createElement_tag(String tag) =>
+ document.$dom_createElement(tag);
$endif
}
« no previous file with comments | « tools/dom/src/dart2js_CustomElementSupport.dart ('k') | tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698