Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23522012: Replace ReceivePorts with asyncStart|End in some tests. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Replace ReceivePorts with asyncStart|End in some tests. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26996

Patch Set 1 #

Patch Set 2 : Remove bad comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -270 lines) Patch
M tests/lib/async/catch_errors10_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors11_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors12_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors13_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors14_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors15_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors16_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors17_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors18_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors19_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors20_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors21_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors22_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors23_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors24_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors25_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors26_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors27_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors28_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors2_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors3_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors4_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors5_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors6_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors7_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors8_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors9_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/catch_errors_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/future_delayed_error_test.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M tests/lib/async/future_test.dart View 1 31 chunks +63 lines, -63 lines 0 comments Download
M tests/lib/async/futures_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/intercept_run_async3_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/intercept_run_async4_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/intercept_run_async5_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/intercept_run_async6_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_async4_test.dart View 2 chunks +7 lines, -1 line 0 comments Download
M tests/lib/async/run_zoned2_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned3_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned5_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned7_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned8_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/async/slow_consumer2_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/async/slow_consumer3_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/async/slow_consumer_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 3 months ago (2013-08-30 16:58:44 UTC) #1
kustermann
LGTM
7 years, 3 months ago (2013-08-30 17:45:43 UTC) #2
floitsch
7 years, 3 months ago (2013-09-02 08:24:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r26996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698