Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: tests/lib/async/catch_errors2_test.dart

Issue 23522012: Replace ReceivePorts with asyncStart|End in some tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove bad comment. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/lib/async/catch_errors28_test.dart ('k') | tests/lib/async/catch_errors3_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:async_helper/async_helper.dart';
5 import "package:expect/expect.dart"; 6 import "package:expect/expect.dart";
6 import 'dart:async'; 7 import 'dart:async';
7 import 'dart:isolate';
8 import 'catch_errors.dart'; 8 import 'catch_errors.dart';
9 9
10 main() { 10 main() {
11 // We keep a ReceivePort open until all tests are done. This way the VM will 11 asyncStart();
12 // hang if the callbacks are not invoked and the test will time out.
13 var port = new ReceivePort();
14 bool futureWasExecuted = false; 12 bool futureWasExecuted = false;
15 // Make sure that `catchErrors` only closes the error stream when the inner 13 // Make sure that `catchErrors` only closes the error stream when the inner
16 // futures are done. 14 // futures are done.
17 catchErrors(() { 15 catchErrors(() {
18 new Future(() { 16 new Future(() {
19 futureWasExecuted = true; 17 futureWasExecuted = true;
20 }); 18 });
21 return 'allDone'; 19 return 'allDone';
22 }).listen((x) { 20 }).listen((x) {
23 Expect.fail("Unexpected callback"); 21 Expect.fail("Unexpected callback");
24 }, 22 },
25 onDone: () { 23 onDone: () {
26 Expect.isTrue(futureWasExecuted); 24 Expect.isTrue(futureWasExecuted);
27 port.close(); 25 asyncEnd();
28 }); 26 });
29 } 27 }
OLDNEW
« no previous file with comments | « tests/lib/async/catch_errors28_test.dart ('k') | tests/lib/async/catch_errors3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698