Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: tests/lib/async/catch_errors9_test.dart

Issue 23522012: Replace ReceivePorts with asyncStart|End in some tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove bad comment. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/async/catch_errors8_test.dart ('k') | tests/lib/async/catch_errors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/catch_errors9_test.dart
diff --git a/tests/lib/async/catch_errors9_test.dart b/tests/lib/async/catch_errors9_test.dart
index 5912bf1ef37461d5c409e99be22a492359d61196..f16bcfb2e8d46cde0f705014e4e4cbf3aa4e7da6 100644
--- a/tests/lib/async/catch_errors9_test.dart
+++ b/tests/lib/async/catch_errors9_test.dart
@@ -2,15 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'package:async_helper/async_helper.dart';
import "package:expect/expect.dart";
import 'dart:async';
-import 'dart:isolate';
import 'catch_errors.dart';
main() {
- // We keep a ReceivePort open until all tests are done. This way the VM will
- // hang if the callbacks are not invoked and the test will time out.
- var port = new ReceivePort();
+ asyncStart();
bool futureWasExecuted = false;
// Test that `catchErrors` waits for `Timer.run` before closing its error
// stream.
@@ -24,6 +22,6 @@ main() {
},
onDone: () {
Expect.isTrue(futureWasExecuted);
- port.close();
+ asyncEnd();
});
}
« no previous file with comments | « tests/lib/async/catch_errors8_test.dart ('k') | tests/lib/async/catch_errors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698