Mirror removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.

Mirror implementation removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.

(API was removed in r29492)

R=ahe@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29698

[gbracha, 2013-09-18 22:11:29]

API lgtm but need to remove newInstanceAsync as well.

https://codereview.chromium.org/23460050/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (left):

https://codereview.chromium.org/23460050/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:587: /**
What about newInstanceAsync? It needs to go too.

[rmacnak, 2013-09-18 23:54:58]

On 2013/09/18 22:11:29, gbracha wrote:
> API lgtm but need to remove newInstanceAsync as well.
> 
> https://codereview.chromium.org/23460050/diff/1/sdk/lib/mirrors/mirrors.dart
> File sdk/lib/mirrors/mirrors.dart (left):
> 
>
https://codereview.chromium.org/23460050/diff/1/sdk/lib/mirrors/mirrors.dart#...
> sdk/lib/mirrors/mirrors.dart:587: /**
> What about newInstanceAsync? It needs to go too.

Done.

[gbracha, 2013-09-18 23:58:02]

lgtm

[rmacnak, 2013-10-22 23:34:41]

Resynced after one month of drift.

[ahe, 2013-10-29 10:18:22]

LGTM!

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right):

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:124: new
Future(()=>lib_mirror.invoke(const Symbol('function'), [123])).then(
Don't use future?

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:376: new
Future(()=>mirror.invoke(const Symbol('+'), [ mirror.reflectee ])).then(
Don't use future?

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:393: new
Future(()=>mirror.invoke(const Symbol('[]'), [ 0 ])).then(
Ditto.

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:463: new
Future(()=>mirror.invoke(const Symbol('method'), [ 1000 ])).then(
Ditto.

https://codereview.chromium.org/23460050/diff/15001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (left):

https://codereview.chromium.org/23460050/diff/15001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:7: import 'dart:async';
Remove import?

[rmacnak, 2013-10-30 17:25:30]

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right):

https://codereview.chromium.org/23460050/diff/15001/runtime/tests/vm/dart/iso...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:124: new
Future(()=>lib_mirror.invoke(const Symbol('function'), [123])).then(
On 2013/10/29 10:18:22, ahe wrote:
> Don't use future?

Actually I will just delete this test. This test has low coverage for a number
of unrelated features. We have more extensive and better organized coverage in
tests/lib/mirrors.

https://codereview.chromium.org/23460050/diff/15001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (left):

https://codereview.chromium.org/23460050/diff/15001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:7: import 'dart:async';
On 2013/10/29 10:18:22, ahe wrote:
> Remove import?

Future is still referenced by the return type of findInContext.  Will be
addressed in a CL lobotomizing findInContext.

[rmacnak, 2013-10-31 21:02:10]

Committed patchset #6 manually as r29698 (presubmit successful).