Mirror removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.

runtime/tests/vm/dart/isolate_mirror_local_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for checking implemention of MirrorSystem when
 // inspecting the current isolate.
 //
 // VMOptions=--enable_type_checks
 
 library isolate_mirror_local_test;
@@ skipping 103 matching lines @@
   Expect.equals(const Symbol('isolate_mirror_local_test'),
                 lib_mirror.qualifiedName);
   Expect.equals(null, lib_mirror.owner);
   Expect.isFalse(lib_mirror.isPrivate);
   Expect.isTrue(lib_mirror.uri.path.contains('isolate_mirror_local_test.dart'));
   Expect.equals("LibraryMirror on 'isolate_mirror_local_test'",
                 lib_mirror.toString());
 
   // Test library invocation by calling function(123).
   Expect.equals(0, global_var);
-  lib_mirror.invokeAsync(const Symbol('function'), [123]).then(
+  new Future(()=>lib_mirror.invoke(const Symbol('function'), [123])).then(

[ahe, 2013/10/29 10:18:22]

Don't use future?

[rmacnak, 2013/10/30 17:25:30]

Actually I will just delete this test. This test has low coverage for a number
of unrelated features. We have more extensive and better organized coverage in
tests/lib/mirrors.

       (InstanceMirror retval) {
         Expect.equals(123, global_var);
         testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(124, retval.reflectee);
         testDone('testRootLibraryMirror');
       });
 
   // Check that the members map is complete.
   List keys = lib_mirror.members.keys.map(MirrorSystem.getName).toList();
@@ skipping 181 matching lines @@
   Expect.isTrue(mirror_lib is LibraryMirror);
 
   // Lookup an interface from a library and make sure it is sane.
   ClassMirror list_intf = core_lib.members[const Symbol('List')];
   Expect.isTrue(list_intf is ClassMirror);
   Expect.equals(const Symbol('List'), list_intf.simpleName);
   Expect.equals(const Symbol('dart.core.List'), list_intf.qualifiedName);
   Expect.isFalse(list_intf.isPrivate);
   Expect.equals(const Symbol('Object'), list_intf.superclass.simpleName);
   Expect.equals(const Symbol('dart.core'), list_intf.owner.simpleName);
-  Expect.isTrue(list_intf.isClass);
   Expect.equals(const Symbol('Iterable'),
                 list_intf.superinterfaces[0].simpleName);
   Expect.equals("ClassMirror on 'List'", list_intf.toString());
 
   // Lookup a class from a library and make sure it is sane.
   ClassMirror oom_cls = core_lib.members[const Symbol('OutOfMemoryError')];
   Expect.isTrue(oom_cls is ClassMirror);
   Expect.equals(const Symbol('OutOfMemoryError'), oom_cls.simpleName);
   Expect.equals(const Symbol('dart.core.OutOfMemoryError'),
                 oom_cls.qualifiedName);
   Expect.isFalse(oom_cls.isPrivate);
   Expect.equals(const Symbol('Object'), oom_cls.superclass.simpleName);
-  Expect.isTrue(oom_cls.defaultFactory == null);
   Expect.equals(const Symbol('dart.core'), oom_cls.owner.simpleName);
-  Expect.isTrue(oom_cls.isClass);
   Expect.equals(const Symbol('Error'), oom_cls.superinterfaces[0].simpleName);
   Expect.equals("ClassMirror on 'OutOfMemoryError'",
                 oom_cls.toString());
   testDone('testLibrariesMap');
 }
 
 void testMirrorSystem(MirrorSystem mirrors) {
   Expect.isTrue(mirrors.isolate.debugName.contains('main'));
   testRootLibraryMirror(mirrors.isolate.rootLibrary);
   testLibrariesMap(mirrors.libraries);
@@ skipping 17 matching lines @@
   Expect.isTrue(foundInterface, '$klass should implement $intfName');
 }
 
 void testIntegerInstanceMirror(InstanceMirror mirror) {
   testImplements(mirror.type, #int);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals(1001, mirror.reflectee);
   Expect.equals("InstanceMirror on 1001", mirror.toString());
 
   // Invoke (mirror + mirror).
-  mirror.invokeAsync(const Symbol('+'), [ mirror ]).then(
+  new Future(()=>mirror.invoke(const Symbol('+'), [ mirror.reflectee ])).then(

[ahe, 2013/10/29 10:18:22]

Don't use future?

       (InstanceMirror retval) {
         testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(2002, retval.reflectee);
         testDone('testIntegerInstanceMirror');
       });
 }
 
 void testStringInstanceMirror(InstanceMirror mirror) {
   testImplements(mirror.type, #String);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals('This\nis\na\nString', mirror.reflectee);
   Expect.equals('InstanceMirror on "This\\nis\\na\\nString"',
                 mirror.toString());
 
   // Invoke mirror[0].
-  mirror.invokeAsync(const Symbol('[]'), [ 0 ]).then(
+  new Future(()=>mirror.invoke(const Symbol('[]'), [ 0 ])).then(

[ahe, 2013/10/29 10:18:22]

Ditto.

       (InstanceMirror retval) {
         testImplements(retval.type, #String);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals('T', retval.reflectee);
         testDone('testStringInstanceMirror');
       });
 }
 
 void testBoolInstanceMirror(InstanceMirror mirror) {
   testImplements(mirror.type, #bool);
@@ skipping 43 matching lines @@
     saw_exception = true;
   }
   Expect.isFalse(saw_exception);
   Expect.equals("InstanceMirror on Instance of 'MyClass'",
                 mirror.toString());
 
   ClassMirror cls = mirror.type;
   Expect.isTrue(cls is ClassMirror);
   Expect.equals(const Symbol('MyClass'), cls.simpleName);
   Expect.equals(const Symbol('MySuperClass'), cls.superclass.simpleName);
-  Expect.isTrue(cls.defaultFactory == null);
   Expect.equals(const Symbol('isolate_mirror_local_test'),
                 cls.owner.simpleName);
-  Expect.isTrue(cls.isClass);
   Expect.equals(const Symbol('MyInterface'), cls.superinterfaces[0].simpleName);
   Expect.equals("ClassMirror on 'MyClass'", cls.toString());
 
   // Invoke mirror.method(1000).
-  mirror.invokeAsync(const Symbol('method'), [ 1000 ]).then(
+  new Future(()=>mirror.invoke(const Symbol('method'), [ 1000 ])).then(

[ahe, 2013/10/29 10:18:22]

Ditto.

       (InstanceMirror retval) {
         testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(1017, retval.reflectee);
         testDone('testCustomInstanceMirror');
       });
 
 }
 
 class MyException implements Exception {
   MyException(this._message);
   final String _message;
   String toString() { return 'MyException: $_message'; }
 }
 
 void main() {
   // When all of the expected tests complete, the exit_port is closed,
   // allowing the program to terminate.
   exit_port = new ReceivePort();
   expectedTests = new Set<String>.from(['testRootLibraryMirror',
                                         'testLibrariesMap',
                                         'testMirrorSystem',
                                         'testIntegerInstanceMirror',
                                         'testStringInstanceMirror',
                                         'testBoolInstanceMirror',
                                         'testNullInstanceMirror',
                                         'testCustomInstanceMirror']);
 
-  // Test that an isolate can reflect on itself.
-  mirrorSystemOf(exit_port.toSendPort()).then(testMirrorSystem);
+  testMirrorSystem(currentMirrorSystem());
 
   testIntegerInstanceMirror(reflect(1001));
   testStringInstanceMirror(reflect('This\nis\na\nString'));
   testBoolInstanceMirror(reflect(true));
   testNullInstanceMirror(reflect(null));
   testCustomInstanceMirror(reflect(new MyClass(17)));
 }