Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 23460050: Mirror removals: async invoke, mirrorSystemOf(port), Mirror.mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | tests/compiler/dart2js_extra/mirror_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index 96671cde8c3d7f49c05491c7112fd136c4bfe682..7143ae384fc152b416ab4b5f62aa00c4f3c71ca1 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -675,15 +675,6 @@ class JsMixinApplication extends JsTypeMirror with JsObjectMirror
"Can't instantiate mixin application '${n(qualifiedName)}'");
}
- Future<InstanceMirror> newInstanceAsync(
- Symbol constructorName,
- List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return new Future<InstanceMirror>(
- () => this.newInstance(
- constructorName, positionalArguments, namedArguments));
- }
-
bool get isOriginalDeclaration => true;
ClassMirror get originalDeclaration => this;
@@ -697,20 +688,6 @@ class JsMixinApplication extends JsTypeMirror with JsObjectMirror
}
abstract class JsObjectMirror implements ObjectMirror {
- Future<InstanceMirror> setFieldAsync(Symbol fieldName, Object value) {
- return new Future<InstanceMirror>(() => this.setField(fieldName, value));
- }
-
- Future<InstanceMirror> getFieldAsync(Symbol fieldName) {
- return new Future<InstanceMirror>(() => this.getField(fieldName));
- }
-
- Future<InstanceMirror> invokeAsync(Symbol memberName,
- List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return new Future<InstanceMirror>(
- () => this.invoke(memberName, positionalArguments, namedArguments));
- }
}
class JsInstanceMirror extends JsObjectMirror implements InstanceMirror {
@@ -722,14 +699,6 @@ class JsInstanceMirror extends JsObjectMirror implements InstanceMirror {
ClassMirror get type => reflectType(reflectee.runtimeType);
- Future<InstanceMirror> invokeAsync(Symbol memberName,
- List<Object> positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return
- new Future<InstanceMirror>(
- () => invoke(memberName, positionalArguments, namedArguments));
- }
-
InstanceMirror invoke(Symbol memberName,
List positionalArguments,
[Map<Symbol,dynamic> namedArguments]) {
@@ -1004,15 +973,6 @@ class JsTypeBoundClassMirror extends JsDeclarationMirror implements ClassMirror
namedArguments);
}
- Future<InstanceMirror> newInstanceAsync(
- Symbol constructorName,
- List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return _class.newInstanceAsync(constructorName,
- positionalArguments,
- namedArguments);
- }
-
JsLibraryMirror get owner => _class.owner;
List<InstanceMirror> get metadata => _class.metadata;
@@ -1031,18 +991,8 @@ class JsTypeBoundClassMirror extends JsDeclarationMirror implements ClassMirror
List<ClassMirror> get superinterfaces => _class.superinterfaces;
- Future<InstanceMirror> getFieldAsync(Symbol fieldName) {
- return _class.getFieldAsync(fieldName);
- }
-
bool get hasReflectedType => _class.hasReflectedType;
- Future<InstanceMirror> invokeAsync(Symbol memberName,
- List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return _class.invokeAsync(memberName, positionalArguments, namedArguments);
- }
-
bool get isPrivate => _class.isPrivate;
bool get isTopLevel => _class.isTopLevel;
@@ -1055,10 +1005,6 @@ class JsTypeBoundClassMirror extends JsDeclarationMirror implements ClassMirror
Type get reflectedType => _class.reflectedType;
- Future<InstanceMirror> setFieldAsync(Symbol fieldName, Object value) {
- return _class.setFieldAsync(fieldName, value);
- }
-
Symbol get simpleName => _class.simpleName;
}
@@ -1313,18 +1259,6 @@ class JsClassMirror extends JsTypeMirror with JsObjectMirror
return reflect(mirror._invoke(positionalArguments, namedArguments));
}
- Future<InstanceMirror> newInstanceAsync(
- Symbol constructorName,
- List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- if (namedArguments != null && !namedArguments.isEmpty) {
- throw new UnsupportedError('Named arguments are not implemented.');
- }
- return new Future<InstanceMirror>(
- () => newInstance(
- constructorName, positionalArguments, namedArguments));
- }
-
JsLibraryMirror get owner {
if (_owner == null) {
if (_jsConstructorOrInterceptor is Interceptor) {
@@ -1583,12 +1517,6 @@ function(reflectee) {
Function.apply(reflectee, positionalArguments, namedArguments));
}
- Future<InstanceMirror> applyAsync(List positionalArguments,
- [Map<Symbol, dynamic> namedArguments]) {
- return new Future<InstanceMirror>(
- () => apply(positionalArguments, namedArguments));
- }
-
String toString() => "ClosureMirror on '${Error.safeToString(reflectee)}'";
// TODO(ahe): Implement these.
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | tests/compiler/dart2js_extra/mirror_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698