Issue 23440034: Make sure we throw the right NSM error when indexing out of range of a variable that can be null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23440034: Make sure we throw the right NSM error when indexing out of range of a variable that can be null. (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make sure we throw the right NSM error when indexing out of range of a variable that can be null. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27476

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 chunk	+18 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
A	tests/language/inference_list_or_null_test.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

7 years, 3 months ago (2013-09-13 12:15:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27476 (presubmit successful).