Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 23440034: Make sure we throw the right NSM error when indexing out of range of a variable that can be null. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 27429)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1244,12 +1244,14 @@
*/
int staticChecks = FULL_CHECK;
- HBoundsCheck(length, index) : super(<HInstruction>[length, index]) {
+ HBoundsCheck(length, index, array)
+ : super(<HInstruction>[length, index, array]) {
instructionType = HType.INTEGER;
}
HInstruction get length => inputs[1];
HInstruction get index => inputs[0];
+ HInstruction get array => inputs[2];
bool isControlFlow() => true;
accept(HVisitor visitor) => visitor.visitBoundsCheck(this);

Powered by Google App Engine
This is Rietveld 408576698