Make sure we throw the right NSM error when indexing out of range of a variable that can be null.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 1958 matching lines @@
       }
       assert(over != null || under != null);
       js.Expression underOver = under == null
           ? over
           : over == null
               ? under
               : new js.Binary("||", under, over);
       js.Statement thenBody = new js.Block.empty();
       js.Block oldContainer = currentContainer;
       currentContainer = thenBody;
-      generateThrowWithHelper('ioore', node.index);
+      generateThrowWithHelper('ioore', [node.array, node.index]);
       currentContainer = oldContainer;
       thenBody = unwrapStatement(thenBody);
       pushStatement(new js.If.noElse(underOver, thenBody), node);
     } else {
-      generateThrowWithHelper('ioore', node.index);
+      generateThrowWithHelper('ioore', [node.array, node.index]);
     }
   }
 
-  void generateThrowWithHelper(String helperName, HInstruction argument) {
+  void generateThrowWithHelper(String helperName, argument) {
     Element helper = compiler.findHelper(new SourceString(helperName));
     world.registerStaticUse(helper);
     js.VariableUse jsHelper =
         new js.VariableUse(backend.namer.isolateAccess(helper));
-    use(argument);
-    js.Call value = new js.Call(jsHelper, [pop()]);
-    attachLocation(value, argument);
+    List arguments = [];
+    var location;
+    if (argument is List) {
+      location = argument[0];
+      argument.forEach((instruction) {
+        use(instruction);
+        arguments.add(pop());
+      });
+    } else {
+      location = argument;
+      use(argument);
+      arguments.add(pop());
+    }
+    js.Call value = new js.Call(jsHelper, arguments);
+    attachLocation(value, location);
     // BUG(4906): Using throw here adds to the size of the generated code
     // but it has the advantage of explicitly telling the JS engine that
     // this code path will terminate abruptly. Needs more work.
     pushStatement(new js.Throw(value));
   }
 
   visitThrowExpression(HThrowExpression node) {
     HInstruction argument = node.inputs[0];
     use(argument);
 
@@ skipping 985 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive(compiler) && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }