Making almost all dom_ methods private. Exceptions will be addressed in a later CL.

Making almost all dom_ methods private. Exceptions will be addressed in a later CL.

Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes. 

BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26605

[Emily Fortuna, 2013-08-22 18:38:50]

Part one of an installment.

[blois, 2013-08-22 20:42:22]

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
File sdk/lib/html/html_common/device.dart (left):

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
sdk/lib/html/html_common/device.dart:5: part of html_common;
Not sure I understand this move- is this moving into dart:html? Is this needed
for this CL?

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
sdk/lib/html/html_common/device.dart:107: var e =
document.$dom_createEvent(eventType);
Should be able to replace with new Event.eventType(eventType);

https://codereview.chromium.org/23055008/diff/10001/tools/dom/src/EventStream...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/23055008/diff/10001/tools/dom/src/EventStream...
tools/dom/src/EventStreamProvider.dart:210:
_target._addEventListener(_eventType, _onData, _useCapture);
As much as I'd like this one made private, it seemed that a number of external
libs may still be using it.

Should we do a deprecation for it?

[Emily Fortuna, 2013-08-22 22:10:10]

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
File sdk/lib/html/html_common/device.dart (left):

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
sdk/lib/html/html_common/device.dart:5: part of html_common;
On 2013/08/22 20:42:23, blois wrote:
> Not sure I understand this move- is this moving into dart:html? Is this needed
> for this CL?

Only needed if this file calls _createEvent(eventType), which currently it does,
which is private and can't be accessed by this file. If we can call new
Event.eventType(eventType) as you suggested, we'll also be making the function
call initEvent (in the Event.eventType constructor), which seems like it will be
doing more work than we have to.

https://codereview.chromium.org/23055008/diff/10001/tools/dom/src/EventStream...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/23055008/diff/10001/tools/dom/src/EventStream...
tools/dom/src/EventStreamProvider.dart:210:
_target._addEventListener(_eventType, _onData, _useCapture);
On 2013/08/22 20:42:23, blois wrote:
> As much as I'd like this one made private, it seemed that a number of external
> libs may still be using it.
> 
> Should we do a deprecation for it?

Done.

[blois, 2013-08-23 15:55:06]

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
File sdk/lib/html/html_common/device.dart (left):

https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
sdk/lib/html/html_common/device.dart:5: part of html_common;
On 2013/08/22 22:10:10, Emily Fortuna wrote:
> On 2013/08/22 20:42:23, blois wrote:
> > Not sure I understand this move- is this moving into dart:html? Is this
needed
> > for this CL?
> 
> Only needed if this file calls _createEvent(eventType), which currently it
does,
> which is private and can't be accessed by this file. If we can call new
> Event.eventType(eventType) as you suggested, we'll also be making the function
> call initEvent (in the Event.eventType constructor), which seems like it will
be
> doing more work than we have to.

It's not called too often and I'd like to keep this file private, but accessible
to the other DOM libs.

[Emily Fortuna, 2013-08-23 16:25:25]

On 2013/08/23 15:55:06, blois wrote:
>
https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
> File sdk/lib/html/html_common/device.dart (left):
> 
>
https://codereview.chromium.org/23055008/diff/10001/sdk/lib/html/html_common/...
> sdk/lib/html/html_common/device.dart:5: part of html_common;
> On 2013/08/22 22:10:10, Emily Fortuna wrote:
> > On 2013/08/22 20:42:23, blois wrote:
> > > Not sure I understand this move- is this moving into dart:html? Is this
> needed
> > > for this CL?
> > 
> > Only needed if this file calls _createEvent(eventType), which currently it
> does,
> > which is private and can't be accessed by this file. If we can call new
> > Event.eventType(eventType) as you suggested, we'll also be making the
function
> > call initEvent (in the Event.eventType constructor), which seems like it
will
> be
> > doing more work than we have to.
> 
> It's not called too often and I'd like to keep this file private, but
accessible
> to the other DOM libs.

Which it is, in the current patchset...

[blois, 2013-08-23 16:33:36]

lgtm

Sorry- it's still marked with a 'D' in the file list for some reason (but has a
diff and no associated 'A').

[Emily Fortuna, 2013-08-23 18:26:07]

Committed patchset #3 manually as r26605 (presubmit successful).