Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 23055008: Making almost all dom_ methods private. Exceptions will be addressed in a later CL. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Node.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate
index 1eb46fa7d4d0089d998f86db7688521e574f7d44..f48bb031f40d0944cd6e28b55357c511d13b5f03 100644
--- a/tools/dom/templates/html/impl/impl_Node.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate
@@ -94,7 +94,7 @@ $endif
Node removeLast() {
final result = last;
if (result != null) {
- _this.$dom_removeChild(result);
+ _this._removeChild(result);
}
return result;
}
@@ -102,7 +102,7 @@ $endif
Node removeAt(int index) {
var result = this[index];
if (result != null) {
- _this.$dom_removeChild(result);
+ _this._removeChild(result);
}
return result;
}
@@ -111,7 +111,7 @@ $endif
if (object is! Node) return false;
Node node = object;
if (!identical(_this, node.parentNode)) return false;
- _this.$dom_removeChild(node);
+ _this._removeChild(node);
return true;
}
@@ -123,7 +123,7 @@ $endif
while (child != null) {
Node nextChild = child.nextNode;
if (test(child) == removeMatching) {
- _this.$dom_removeChild(child);
+ _this._removeChild(child);
}
child = nextChild;
}
@@ -142,7 +142,7 @@ $endif
}
void operator []=(int index, Node value) {
- _this.$dom_replaceChild(value, this[index]);
+ _this._replaceChild(value, this[index]);
}
Iterator<Node> get iterator => _this.$dom_childNodes.iterator;
@@ -224,7 +224,7 @@ $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
// TODO(vsm): Use the native remove when available.
if (this.parentNode != null) {
final Node parent = this.parentNode;
- parentNode.$dom_removeChild(this);
+ parentNode._removeChild(this);
}
}
@@ -235,7 +235,7 @@ $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
Node replaceWith(Node otherNode) {
try {
final Node parent = this.parentNode;
- parent.$dom_replaceChild(otherNode, this);
+ parent._replaceChild(otherNode, this);
} catch (e) {
};

Powered by Google App Engine
This is Rietveld 408576698